[Due for payment 2025-04-17] [$250] iOS mWeb - Workspace - Offline indicator isn't sticking to the keyboard

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.19-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58909
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Apple iPhone 12 Pro / Safari
App Component: Workspace Settings

Action Performed:

1. Open the app
2. Log in with a Gmail account that is an admin of a workspace
3. Navigate to Workspace settings - Overview - Default currency
4. Go offline
5. Tap inside the "Default currency" textbox to open the keyboard

Expected Result:

Offline indicator should be visible when the keyboard is open.

Actual Result:

Offline indicator isn't sticking to the keyboard.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6782471_1742975180635.JRUB3184.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904908918225594554
• Upwork Job ID: 1904908918225594554
• Last Price Increase: 2025-04-02

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nlemma]

Issue was found while executing QA for PR #58909

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The offline indicator doesn't move up when the keyboard shows on the workspace overview currency page.

What is the root cause of that problem?

The offline indicator doesn't move up because the page isn't resized. We don't pass the shouldEnableMaxHeight to the ScreenWrapper.

App/src/pages/workspace/WorkspaceOverviewCurrencyPage.tsx

Lines 45 to 59 in 83994af

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceOverviewCurrencyPage.displayName}
	>
	<HeaderWithBackButton
	title={translate('workspace.editor.currencyInputLabel')}
	onBackButtonPress={() => Navigation.goBack()}
	/>
	<CurrencySelectionList
	searchInputLabel={translate('workspace.editor.currencyInputLabel')}
	onSelect={onSelectCurrency}
	initiallySelectedCurrencyCode={policy?.outputCurrency}
	/>
	</ScreenWrapper>

Comapred to the iou currency selection page.

App/src/pages/iou/request/step/StepScreenWrapper.tsx

Lines 58 to 63 in 83994af

	return (
	<ScreenWrapper
	includeSafeAreaPaddingBottom={includeSafeAreaPaddingBottom}
	onEntryTransitionEnd={onEntryTransitionEnd}
	testID={testID}
	shouldEnableMaxHeight={DeviceCapabilities.canUseTouchScreen()}

What changes do you think we should make in order to solve the problem?

Enable shouldEnableMaxHeight in WorkspaceOverviewCurrencyPage too.

asd.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[chrispader]

@nlemma @slafortune the proposal from @bernhardoj is correct! This is not a bug caused by #58909 then, but already was an issue before.

Let me know if i should include the fix in #59144, but the props definitely go to @bernhardoj! 🙌🏼

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904908918225594554

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)