[Due for payment 2025-04-17] [Due for payment 2025-04-16] [$250] Full story: Loading spinner displayed and user stuck after signin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: No staging URL
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

1. Create account and validate the account
2. Go to https://use.expensify.com/savings-calculator.
3. Enter your email in the form to get started.

Expected Result:

User able to login successfully

Actual Result:

Continuous loading spinner displayed. (Able to reproduce consistently but not everytime)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

The Full story session is in OP

Recording.1102.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907181592409680264
• Upwork Job ID: 1907181592409680264
• Last Price Increase: 2025-04-01
• Automatic offers:
• nkdengineer | Contributor | 106973201

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Continuous loading spinner displayed. (Able to reproduce consistently but not everytime)

What is the root cause of that problem?

When we transition from OD to ND, Logout API is called. It can be called with the sortLiveToken of the new user; in this case, the backend response with 407 error

App/src/libs/Middleware/Reauthentication.ts

Lines 69 to 70 in e79a743

	if (data.jsonCode === CONST.JSON_CODE.NOT_AUTHENTICATED) {
	if (isOffline()) {

And the reauthen logic isn't skipped because !shouldRetry && !apiRequestType is false

App/src/libs/Middleware/Reauthentication.ts

Line 85 in e79a743

if ((!shouldRetry && !apiRequestType) || skipReauthentication) {

After we reauthen successfully, the Logout API is recalled here, and because the token is still an old token, the backend returns 407 error again. It causes an infinite loop LogOut --> Authenticate --> Logout --> Authenticate

App/src/libs/Middleware/Reauthentication.ts

Lines 102 to 105 in e79a743

	return reauthenticate(request?.commandName)
	?.then((authenticateResponse) => {
	if (isFromSequentialQueue || apiRequestType === CONST.API_REQUEST_TYPE.MAKE_REQUEST_WITH_SIDE_EFFECTS) {
	return processWithMiddleware(request, isFromSequentialQueue);

What changes do you think we should make in order to solve the problem?

I think we should remove !apiRequestType check here since all APIs will have apiRequestType. And we can see that we don't want the retry the Logout API here.

App/src/libs/Middleware/Reauthentication.ts

Line 85 in e79a743

if ((!shouldRetry && !apiRequestType) || skipReauthentication) {

Or we can add skipReauthentication as true for Logout API.

App/src/libs/actions/Session/index.ts

Line 198 in e79a743

shouldRetry: false,

Or we can return early if the request is Logout API here

App/src/libs/Middleware/Reauthentication.ts

Line 85 in e79a743

if ((!shouldRetry && !apiRequestType) || skipReauthentication) {

Here are the steps to reproduce this issue consistently

1. Sign in to an account in NewDot
2. When we transition from OD, copy the URL, close the tab
3. In the NewDot tab, open the console and set the authToken to the sortLiveToken in the URL we copied Onyx.merge("session", {"authToken": ${copiedToken}});
4. Access the copied URL

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mountiny]

@kubabutkiewicz Any updates on this one?

[kubabutkiewicz]

Yes, I'm preparing a PR with changes suggested by @WojtekBoman and my findings.

[kubabutkiewicz]

Unfortunately during the tests I was able to again reproduce that again after few tries so I will look again into it

[nkdengineer]

@kubabutkiewicz Based on the video #59409 (comment), I think this PR doesn't fix this bug because the bug here is that we are stuck at the transition loading screen. cc @mountiny