[Due for payment 2025-05-28] [$250] Android - When entering tax rate, digit overlap with percentage symbol

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.23-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Slotwoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Redmi note 19s androud 13
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Go to workspace settings - more features - enable taxes
3. Tap taxes
4. Tap value
5. Enter 8 digit repeatedly

Expected Result:

When entering tax rate, digit must not overlap with percentage symbol.

Bug not reproducible in v9.1.20-0

Actual Result:

When entering tax rate, digit overlap with percentage symbol.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6791384_1743699201844.az_recorder_20250403_221706.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907928733770489004
• Upwork Job ID: 1907928733770489004
• Last Price Increase: 2025-04-17
• Automatic offers:
• linhvovan29546 | Contributor | 107019925

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021907928733770489004

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When entering tax rate, digit overlap with percentage symbol.

What is the root cause of that problem?

We are using autoGrow for AmountTextInput

App/src/components/AmountTextInput.tsx

Line 63 in c91bf20

autoGrow

that means the input has the flexible width, and it will be updated in onLayout, so if users add numbers, the width is longer than the container and it can be updated only when onLayout is triggered

What changes do you think we should make in order to solve the problem?

We should add styles.overflowHidden for containerStyles below this line

containerStyles={styles.overflowHidden}

We also can add styles.overflowHidden to TextInput if autoGrow is true

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Style issue

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result

Screen.Recording.2025-04-04.at.11.44.36.mov

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[dangrous]

I can handle internal review on this one when it's ready!