[$250] Expense - Skeleton is displayed in distance expense details after closing distance RHP

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.23-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Android 13/ Chrome
App Component: Money Requests

Action Performed:

1. Sign in to staging.new.expensify.com
2. Navigate to a workspace with distance rates feature enabled
3. Create a distance expense in workspace
4. Navigate to expense details of expense created in step 3
5. Click on the distance
6. Click on back button on distance RHP or click outside RHP

Expected Result:

Distance RHP Closes and expense details are shown with no lagging

Actual Result:

Loading skeleton is seen before expense details are displayed

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909616600713872430
• Upwork Job ID: 1909616600713872430
• Last Price Increase: 2025-04-22
• Automatic offers:
• nkdengineer | Contributor | 107049837

Issue Owner

Current Issue Owner: @MarioExpensify

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Loading skeleton is seen before expense details are displayed

What is the root cause of that problem?

When we close the distance page, OpenReport API is called here so the Skelenton is displayed.

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Lines 248 to 252 in c91bf20

	// If the user opens IOURequestStepDistance in offline mode and then goes online, re-open the report to fill in missing fields from the transaction backup
	if (!transaction?.reportID) {
	return;
	}
	openReport(transaction?.reportID);

What changes do you think we should make in order to solve the problem?

It was added in this PR to fetch the detail of the distance request if we create a distance request offline and close the IOURequestStepDistance online to fetch the distance data. But we can improve this to only call the OpenReport API if the transactionBackup doesn't have the route.

if (!transaction?.reportID || hasRoute(transaction, true)) {
    return;
}
openReport(transaction?.reportID);

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Lines 248 to 252 in c91bf20

	// If the user opens IOURequestStepDistance in offline mode and then goes online, re-open the report to fill in missing fields from the transaction backup
	if (!transaction?.reportID) {
	return;
	}
	openReport(transaction?.reportID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[yaqoob2ishaq4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When closing the Distance RHP, a loading skeleton appears before showing expense details, causing a short delay.

What is the root cause of that problem?

The openReport(transaction?.reportID); API call runs every time the Distance RHP closes, even when route details exist in the Memory (React Native Onyx), causing unnecessary loading.

What changes do you think we should make in order to solve the problem?

change in file
src/pages/iou/request/step/IOURequestStepDistance.tsx

online: 249 change the condition to prevent redundant API calls:
if (!transaction?.reportID) {

TO

if (!transaction?.reportID || hasRoute(transaction, true)) {
    return;
}
openReport(transaction?.reportID);

This ensures data is only fetched when necessary, eliminating the loading skeleton.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Close Distance RHP and verify no loading skeleton appears.

Create a distance expense offline, go online, and ensure correct updates.

Ensure no unnecessary API calls occur when closing RHP multiple times.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909616600713872430

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)