[HOLD for payment 2021-11-22] Mini action menu doesn't disappear when opening and closing an attachment preview - Reported by: @Santhosh-Sellavel

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation
2. Send an image
3. Open the image preview
4. Click on the top right X to close the modal
5. Hover the cursor over other message (that's not the one with the attachment)

Expected Result:

There's only 1 mini action menu displayed over the message that's being hovered on.

Actual Result:

There's 2 mini action menus displayed, one over the attachment message and one over the hovered message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2021-10-20.at.5.39.20.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634732025490800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[TomatoToaster]

Ah interesting. I want to work on this for a little bit and see if I can find a solution. If I can't find it quickly I'll put this into the upwork pool.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[TomatoToaster]

Ok let's make this external, dropping it in the pool.

[sidferreira]

@TomatoToaster @bfitzexpensify

Proposal

According my research, the problem is that the AttachmentModal tricks a bit the <Hoverable resetsOnClickOutside={false}> at ReportActionItem.js, keeping the hovered prop as true after it loses the focus.

Changing resetsOnClickOutside={false}> to resetsOnClickOutside (true) seems to fix the issue.