[Due for payment 2025-04-17] [Due for payment 2025-04-16] Android - Device back button is not responsive after closing context menu

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

1. Launch Expensify app.
2. Go to chat.
3. Long press on any message.
4. Tap outside the context menu to close it.
5. Tap device back button.

Expected Result:

App will return to LHN.

Actual Result:

Device back button is not responsive after closing context menu

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6795558_1744072674543.1744072547419_Screen_Recording_20250408_083537_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 04:54:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Device back button is not responsive after closing context menu

What is the root cause of that problem?

• We have logic to handle the device back button in the following section:
  

  App/src/components/Modal/BottomDockedModal/index.tsx

  Lines 81 to 98 in 689e60c

  	useEffect(() => {
  	const deviceEventListener = DeviceEventEmitter.addListener('didUpdateDimensions', handleDimensionsUpdate);
  	if (getPlatform() === CONST.PLATFORM.WEB) {
  	document.body.addEventListener('keyup', handleEscape, {capture: true});
  	} else {
  	backHandlerListener.current = BackHandler.addEventListener('hardwareBackPress', onBackButtonPressHandler);
  	}
  	return () => {
  	if (getPlatform() === CONST.PLATFORM.WEB) {
  	document.body.removeEventListener('keyup', handleEscape, {capture: true});
  	} else {
  	backHandlerListener.current?.remove();
  	}
  	deviceEventListener.remove();
  	};
  	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
  	}, []);

  .
  However, the issue is that the event listener function is not updated when the isVisible prop changes. As a result, the listener may use stale values of isVisible, leading to incorrect behavior when the modal visibility toggles. In detail, the isVisible uses the stale values true, so it calls:

App/src/components/Modal/BottomDockedModal/index.tsx

Line 65 in 689e60c

onBackButtonPress();

instead of the default device back button behavior.

What changes do you think we should make in order to solve the problem?

• We should add isVisible or onBackButtonPressHandler as a dependency to the effect at:
  

  App/src/components/Modal/BottomDockedModal/index.tsx

  Line 98 in 689e60c

  }, []);

  .
  This ensures that the event listener is re-registered with the latest value of isVisible, keeping the behavior in sync with the modal's visibility state.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

• Update:

App/src/components/Modal/BottomDockedModal/index.tsx

Line 64 in 689e60c

if (isVisible) {

        if (isVisibleRef.current) {

with:

    const isVisibleRef = useRef(isVisible)
    isVisibleRef.current = isVisible