[Due for payment 2025-04-30] [$250] Android - Empty workspace name for first workspace created in new account

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Tecno spark 20/ Android 13
App Component: Workspace Settings

Action Performed:

1. Open app
2. Sign in with a new account
3. Finish the onboarding flow
4. Navigate to workspace > Create new workspace

Expected Result:

Confirm workspace page opens with a suggested workspace name

Actual Result:

Workspace name is empty in confirm page for new workspace in new account.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912156454024432800
• Upwork Job ID: 1912156454024432800
• Last Price Increase: 2025-04-15
• Automatic offers:
• nkdengineer | Contributor | 106960682

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 05:06:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name is empty in confirm page for new workspace in new account.

What is the root cause of that problem?

Here is the logic we used to get the default workspace name

App/src/libs/actions/Policy/Policy.ts

Lines 1628 to 1630 in 689e60c

	const emailParts = email ? email.split('@') : sessionEmail.split('@');
	if (!emailParts || emailParts.length !== 2) {
	return '';

if email is empty, we will use sessionEmail.

In native platform the currentUrl is empty, so the email is empty too.

sessionEmail is also empty at this point because it hasn't been loaded yet.

What changes do you think we should make in order to solve the problem?

We should get the sessionEmail in WorkspaceConfirmationForm

    const [currentUserLogin, metadata] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.email});
...
    const defaultWorkspaceName = generateDefaultWorkspaceName(policyOwnerEmail || currentUserLogin);

and render the input when metadata.status === 'loaded'

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add ui test to verify the input has data when render WorkspaceConfirmationPage

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021912156454024432800

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[nkdengineer]

@jayeshmangwani Do you agree with my proposal above?

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty workspace name for first workspace created in new account

What is the root cause of that problem?

In this case of the ticket, the policyOwnerEmail is empty because the data is not available from the URL on the non-native platform.

App/src/pages/workspace/WorkspaceConfirmationPage.tsx

Line 25 in ceeeaf6

const policyOwnerEmail = currentUrl ? new URL(currentUrl).searchParams.get('ownerEmail') ?? '' : '';

App/src/components/WorkspaceConfirmationForm.tsx

Line 88 in adecd13

const defaultWorkspaceName = generateDefaultWorkspaceName(policyOwnerEmail);

and with that, we will use sessionEmail to generateDefaultWorkspaceName

App/src/libs/actions/Policy/Policy.ts

Line 1631 in 76442fc

const emailParts = email ? email.split('@') : sessionEmail.split('@');

But for the first time, the sessionEmail is empty because the value of sessionEmail is returned late, after generateDefaultWorkspaceName is called, causing generateDefaultWorkspaceName to be empty. sessionEmail is empty because Policy.ts has not been called to initialize, and the data is not ready to be used.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we should initialize Policy.ts to ensure the callback from Onyx is ready, allowing the data to be available before being used inside a function/component.

And a way to implement a fix for this issue, similar to the solution above, would look something like this:

We call generateDefaultWorkspaceName in WorkspacesListPage to initialize sessionEmail before navigating to WorkspaceConfirmationPage

App/src/pages/workspace/WorkspacesListPage.tsx

Line 487 in 785a0fd

onCtaPress={() => interceptAnonymousUser(() => Navigation.navigate(ROUTES.WORKSPACE_CONFIRMATION.getRoute(ROUTES.SETTINGS_WORKSPACES.route)))}

    onPress={() =>
        interceptAnonymousUser(() => {
            generateDefaultWorkspaceName();
            InteractionManager.runAfterInteractions(() => {
                Navigation.navigate(ROUTES.WORKSPACE_CONFIRMATION.getRoute(ROUTES.SETTINGS_WORKSPACES.route));
            });
        })
    }

or

App/src/pages/workspace/WorkspacesListPage.tsx

Line 452 in 785a0fd

    useEffect(() => {
        generateDefaultWorkspaceName();
    }, []);

or

we create empty function in side Policy.ts

https://github.com/Expensify/App/blob/76442fc4b42c0156c0ae9cf5e40449fb923467ec/src/libs/actions/Policy/Policy.ts

  function initPolicys() {}

and call it at WorkspacesListPage.tsx#L452 to init Policy

    useEffect(() => {
        initPolicys();
    }, []);

Screen.Recording.2025-04-17.at.11.15.45.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.