[Due for payment 2025-05-05] [$250] Travel - Upgrade banner incorrectly displayed for public domain account

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5892933&group_by=cases:section_id&group_id=314227&group_order=asc
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Workspace Settings

Action Performed:

1. Log in to the ND with a new Gmail account
2. Select any onboarding except the Manage my team's expenses
3. Click on the FAB
4. Click on the Book Travel button
5. Click on the Upgrade button
6. Click on the Confirm button to create a WS
7. Click on the Book Travel button again

Expected Result:

The app should display a clear message advising the user to use a private domain in order to access the Travel function immediately after clicking the Book Travel button.

The private domain warning should be shown first, before we ask the user to upgrade their subscription.

Actual Result:

The app displays an Upgrade banner recommending users switch to a workspace, but also shows a conflicting message suggesting they need a private domain—causing confusion for users with public domain accounts.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6795925_1744110444346.Travel_public_domain.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910834762912368647
• Upwork Job ID: 1910834762912368647
• Last Price Increase: 2025-04-11
• Automatic offers:
• daledah | Contributor | 106959040

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 14:08:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Travel - Upgrade banner incorrectly displayed for public domain account

What is the root cause of that problem?

App/src/components/BookTravelButton.tsx

Lines 98 to 100 in c53e6a9

	if (groupPaidPolicies.length < 1) {
	Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
	return;

Here we navigate the user to upgrade the policy before checking if there is TRAVEL_PUBLIC_DOMAIN_ERROR

What changes do you think we should make in order to solve the problem?

we need to move

App/src/components/BookTravelButton.tsx

Lines 98 to 105 in e7a9622

	if (groupPaidPolicies.length < 1) {
	Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
	return;
	}
	if (!isPaidGroupPolicy(policy)) {
	setErrorMessage(translate('travel.termsAndConditions.defaultWorkspaceError'));
	return;

Between

App/src/components/BookTravelButton.tsx

Line 134 in e7a9622

if (adminDomains.length === 0) {

and

App/src/components/BookTravelButton.tsx

Line 137 in e7a9622

const domain = adminDomains.at(0) ?? CONST.TRAVEL.DEFAULT_DOMAIN;

Like this

if (adminDomains.length === 0) {
    Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR);
    return;
}

if (groupPaidPolicies.length < 1) {
    Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
    return;
}

if (!isPaidGroupPolicy(policy)) {
    setErrorMessage(translate('travel.termsAndConditions.defaultWorkspaceError'));
    return;
}

if (adminDomains.length === 1) {
    const domain = adminDomains.at(0) ?? CONST.TRAVEL.DEFAULT_DOMAIN;

Explanation:

• First of all we will check if adminDomains.length === 0 then show the public domain error
• If the adminDomains.length > 0 (we skip the first check) but groupPaidPolicies.length < 1 ask the user to upgrade the policy and in this case we will not display domain error

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

In my current proposed solution we'll only display Upgrade banner if adminDomains.length === 1 but in cases where user will have more than one adminDomains and we navigate the user to TRAVEL_DOMAIN_SELECTOR Upgrade banner will not show up

Solution

Just after checking adminDomains.length === 0 we should check groupPaidPolicies.length < 1 and display upgrade banner in necessary regardless of adminDomains.length

const adminDomains = getAdminsPrivateEmailDomains(policy);
if (adminDomains.length === 0) {
    Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR);
} else if (groupPaidPolicies.length < 1) {
    Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
} else if (!isPaidGroupPolicy(policy)) {
    setErrorMessage(translate('travel.termsAndConditions.defaultWorkspaceError'));
} else if (adminDomains.length === 1) {
    const domain = adminDomains.at(0) ?? CONST.TRAVEL.DEFAULT_DOMAIN;
    if (isEmptyObject(policy?.address)) {
        // Spotnana requires an address anytime an entity is created for a policy
        Navigation.navigate(ROUTES.TRAVEL_WORKSPACE_ADDRESS.getRoute(domain));
    } else {
        navigateToAcceptTerms(domain, !!isUserValidated);
    }
} else {
    Navigation.navigate(ROUTES.TRAVEL_DOMAIN_SELECTOR);
}
}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app displays an Upgrade banner recommending users switch to a workspace, but also shows a conflicting message suggesting they need a private domain—causing confusion for users with public domain accounts.

What is the root cause of that problem?

When clicking book a trip button, we check if user has paid policies first:

App/src/components/BookTravelButton.tsx

Lines 98 to 101 in 9eb3655

	if (groupPaidPolicies.length < 1) {
	Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
	return;
	}

What changes do you think we should make in order to solve the problem?

We should handle domain error before checking for paid policy in this case.

Move this

App/src/components/BookTravelButton.tsx

Lines 133 to 135 in 9eb3655

	const adminDomains = getAdminsPrivateEmailDomains(policy);
	if (adminDomains.length === 0) {
	Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR);

To before this

App/src/components/BookTravelButton.tsx

Lines 98 to 101 in 9eb3655

	if (groupPaidPolicies.length < 1) {
	Navigation.navigate(ROUTES.TRAVEL_UPGRADE);
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[sakluger]

I think that the correct solution involves switching the order of the two modals (first show the private domain requirement, then show the subscription upgrade requirement). I'm verifying in Slack before adding any labels: https://expensify.slack.com/archives/C05S5EV2JTX/p1744127653230089

[sakluger]

I bumped the Slack thread.

[samranahm]

Proposal updated
Results

• With public domain

public.domain.mp4

• With private domain

private.doamin.mp4

[samranahm]

I think that the correct solution involves switching the order of the two modals (first show the private domain requirement, then show the subscription upgrade requirement). I'm verifying in Slack before adding any labels: https://expensify.slack.com/archives/C05S5EV2JTX/p1744127653230089

@sakluger I have updated my proposal with current expected results, please let me know if we decide to change anything after discussing in slack since i currently don't have access to this Thread.
Thank you

[sakluger]

I confirmed that the order should be switched. We should show the private domain requirement first, and only show the upgrade subscription prompt to customers on a private email domain.

I updated the original description accordingly.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910834762912368647