[Due for payment 2025-04-28] Update Company Cards page to potentially show domain feeds

[puneetlath]

Part of the Cross compatible Corporate Cards project

Main issue: https://github.com/Expensify/Expensify/issues/467915
Doc section: https://docs.google.com/document/d/1KHrQgvdZWvCwUkptjjW_oqnl0umyVNiPe7KIHCD1pBA/edit?tab=t.0#heading=h.hn90zqqqm7w9

Feature Description

Let's update the Third Party Company Cards page of the workspace editor to display domain feeds as described in the doc here.

To do this we will need to:

1. Support showing domain third party card feeds when the current workspace is set as the primary policy for the feed. We will know this is the case if the Expensify Card settings in Onyx have the current workspace set as the preferredPolicy like below on the domain_member nvp data.
2. We should show only the domain feed if there is no workspace feed set up
3. We should show the feed selector, if there is a workspace feed and some amount of domain feeds. Or if there are multiple domain feeds
4. Everything else should work just like it currently does

Onyx shape:

{
	"onyxData": [
		{
			"key": "sharedNVP_private_domain_member_19527211",
			"onyxMethod": "set",
			"value": {
				"settings": {
					"discover.com": {
						"asrEnabled": false,
						"forceReimbursable": "force_no",
						"liabilityType": "corporate",
						"preferredPolicy": "8548D13C46AEFD4B",
						"reportTitleFormat": "",
						"shouldApplyCashbackToBill": true,
						"statementPeriodEndDay": 1,
						"uploadLayoutSettings": []
					}
				}
			}
		}
	]
}

Manual Test Steps

1. Create an account that is an admin on domainA and policyB
2. Add an third party domain feed to domainA and set policyB as the preferred policy
3. Open policyB in NewDot and go to the Company Cards page
4. Make sure the feed shows up and you can assign cards, edit the settings, etc
5. Create a new domainC same account as admin on the domain
6. Add an third party domain feed to domainC and set policyB as the preferred policy
7. Open policyB in NewDot and go to the Company Cards page
8. Make sure both feeds shows up and you can assign cards, edit the settings, etc
9. Add a workspace third party feed to policyB
10. Open policyB in NewDot and go to the Company Cards page
11. Make sure all three feeds shows up and you can assign cards, edit the settings, etc

Automated Tests

tbd

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[DylanDylann]

@puneetlath could I take over this task as C+ reviewer? I already worked on the workspace feed and company feed before

[puneetlath]

Sure, sounds good.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

UPD:
Working in progress on this one. I'm waiting for the BE to be deployed (it should be today) so I can test updates over the real data to make sure everything works as expected.

[VickyStash]

UPD:
Today I needed to switch on some deploy blockers.
Also, it looks like the OpenPolicyCompanyCardsPage API updates isn't live yet ⌛

[VickyStash]

Right now even without any changes on the FE side, I can see the Amex feed added to the domain in the OldDot in the NewDot.

Though I have some problems with cards display testing because of the issue I've reported here: https://callstack-hq.slack.com/archives/C07NMDKEFMH/p1744297195629639?thread_ts=1743507271.676259&cid=C07NMDKEFMH

Overall, it feels like it should work as is. Just a couple of questions from my side to confirm:

1. Does the selector look as expected to you? For example, it says Direct feed, is it expected?
2. Can someone with several domain third-party bank cards in the OD check how the ND app handles its display right now (Company cards section)? Specifically, how different bank cards are displayed. I mean I see that Amex displays okay as a feed, but it would be great to check Chase, Wells Fargo, etc.
3. Right now, the Company Cards menu item displays in the workspace menu only if the Company Cards feature is on. I guess there can be the case when users have domain cards, but they didn't turn on this feature toggle, so they won't see the Company Cards page. Should we do anything about it?

cc @puneetlath @mountiny