Skip to content

Expense - Approve button appears even when Prevent Self Approval is enabled #59901

@IuliiaHerets

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #58660
Email or phone of affected tester (no customers): biruknew45+ggk78j@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Chat Report View

Action Performed:

Precondition -
Create a workspace and add an approver and submitter
Configure the workflow such that the submitter submits to the Approver and forwards to Submitter
Enable Prevent self-approvals on the workspace
Enable delayed submission

  1. Go to https://staging.new.expensify.com
  2. As an admin, add the submitter user as the category approver for a category. (any category)
  3. As the submitter, create an expense and categorize it with that same category.
  4. As the submitter, go to details and click on the submit button
  5. Click on approve button

Expected Result:

The approve button shouldn't appear or should be disabled.

Actual Result:

Approve button appears even when Prevent Self Approval is enabled. and it causes an error when clicked.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6796958_1744190145093.bandicam_2025-04-09_11-57-20-340.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lydiabarclay

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions