[Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+780473@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Go to Reports.
5. Go to Expense Reports.
6. Click on the expense report from Step 3.
7. Send a user mention who is not a member of the expense report.
8. Refresh the page if whisper does not show up.

Expected Result:

Invite user whisper is accompanied by Concierge user name and avatar.

Actual Result:

Invite user whisper is missing Concierge user name and avatar.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912140453301034956
• Upwork Job ID: 1912140453301034956
• Last Price Increase: 2025-04-15
• Automatic offers:
• gijoe0295 | Contributor | 106949048

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 18:39:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite user whisper is missing Concierge user name and avatar

What is the root cause of that problem?

We will display a message as group (hide sender, because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action:

App/src/libs/ReportActionsUtils.ts

Lines 667 to 668 in 17615a1

	if (!currentAction || !nextAction) {
	return true;

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Lines 290 to 292 in 11a424a

	const displayAsGroup =
	!isConsecutiveChronosAutomaticTimerAction(visibleReportActions, index, chatIncludesChronosWithID(reportAction?.reportID)) &&
	hasNextActionMadeBySameActor(visibleReportActions, index);

Note that, "next" here means the above message in display order, because messages are displayed in reverse order. In this case, the nextAction for the actionable message should be the first message with index 0 (the mention message). But we cannot find it because the loop here stops at 1 (i >0):

App/src/libs/ReportActionsUtils.ts

Lines 586 to 587 in 17615a1

	function findNextAction(reportActions: ReportAction[], actionIndex: number): OnyxEntry<ReportAction> {
	for (let i = actionIndex - 1; i > 0; i--) {

That means any message appears in the second place will hide sender. For example, if another user sends a message here, its sender would be hidden as well even though the first message sender and the second's are not the same.

What changes do you think we should make in order to solve the problem?

Update the loop condition to be i >= 0.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[gijoe0295]

@greg-schroeder Can you take a look?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021912140453301034956

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@gijoe0295 Can you still reproduce the bug? The expense chat loads in RHP in my case (maybe we reverted a PR?)

because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action

I think this is unintended, this comment states that we would return false but true is returned instead

App/src/libs/ReportActionsUtils.ts

Lines 666 to 670 in 316a0d1

	// It's OK for there to be no previous action, and in that case, false will be returned
	// so that the comment isn't grouped
	if (!currentAction || !nextAction) {
	return true;
	}