[Due for payment 2025-05-08] [$250] Web - "This chat doesn't exist" error message is duplicated in Reports section

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.26-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #59796
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Chat Report View

Action Performed:

1. Open the ND app or access staging.new.expensify.com
2. Log into an older account (I used a HT account)
3. Go to Reports > Expense Reports > Click on an older report that has had its chat deactivated

Expected Result:

User expects that an error message is shown saying that the chat cant be found because the chat is no longer active

Actual Result:

The error message is duplicated, one of the messages is centered and the other is aligned to the left and hyperlinked.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/e3893a3b-865c-435d-a47e-df22a0d1705f

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910457821293052264
• Upwork Job ID: 1910457821293052264
• Last Price Increase: 2025-04-10

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The not found page in search report page shows 2 chat doesn't exist message.

What is the root cause of that problem?

We can see that both subtitle key and link key is set.

App/src/pages/Search/SearchMoneyRequestReportPage.tsx

Lines 136 to 143 in 9629c30

	<FullPageNotFoundView
	shouldShow={shouldShowNotFoundPage}
	subtitleKey="notFound.noAccess"
	subtitleStyle={[styles.textSupporting]}
	shouldDisplaySearchRouter
	shouldShowBackButton={shouldUseNarrowLayout}
	onBackButtonPress={Navigation.goBack}
	linkKey="notFound.noAccess"

The link key tells that the linked action isn't found, but there is no linked action in this case. It must be an overlook when implemented because we also have it on report screen, but only shown when linking to an action, but not found.

App/src/pages/home/ReportScreen.tsx

Lines 749 to 750 in 248f253

	shouldShowLink={shouldShowNotFoundLinkedAction}
	linkKey="notFound.noAccess"

What changes do you think we should make in order to solve the problem?

Since we can't link action on search report page, we can just remove the linkKey.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910457821293052264

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[acdtunes]

Please re-state the problem that we are trying to solve in this issue.

The problem is that the “This chat doesn’t exist” error message is displayed twice in the Reports section of the app. Users see both a centered message and a left-aligned hyperlinked message, which creates confusion and a poor user experience.

What is the root cause of that problem?

The root cause is that both the subtitle and link properties are set in the error view configuration on the Search Report page. Specifically, in SearchMoneyRequestReportPage.tsx (lines 136–143), both subtitleKey="notFound.noAccess" and linkKey="notFound.noAccess" are defined, even though no linked action is intended in this context. This configuration inadvertently results in the duplicated error message.

What changes do you think we should make in order to solve the problem?

To solve the problem, we should remove the linkKey from the FullPageNotFoundView configuration in the Search Report page. Since there isn’t an appropriate action to link to in this case, eliminating the linkKey will ensure that only the singular, correctly formatted error message (the subtitle) is displayed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
• Error Message Display: Verify that when a report with a deactivated chat is opened, only one error message (“This chat doesn’t exist”) is displayed.
• Link Absence: Ensure that the error message does not include a hyperlink when no valid linked action is available.
• Cross-Platform Consistency: Test the error display on all supported platforms (Android, iOS, Web, Desktop) to guarantee consistent behavior.
• Regression Testing: Include a test case that covers changes to the configuration keys in both the Search Report and Report screens to catch any unintended reintroductions of duplicate messages.

What alternative solutions did you explore? (Optional)

An alternative solution could be to conditionally render the linkKey only if a valid linked action exists. This would involve adding logic to check for the presence of a linked action before including the linkKey in the view configuration. However, given that the Search Report page isn’t intended to display any link, the simpler and more direct solution is to remove the linkKey entirely.

[jjcoffee]

@bernhardoj's proposal LGTM!

🎀👀🎀 C+ reviewed