[HOLD https://github.com/Expensify/App/issues/60214] [$250] Expense - Submit button on expense preview shows 0.00 after categorizing expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.26-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sd3480@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Have a workspace with "Delay submissions" and "Add approvals" enabled.
• Have self DM. (please try Create an unreported expense on OD to trigger self DM in ND).

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track an expense in self DM.
4. Click Categorize it.
5. Select a category, enter merchant and submit the expense.

Expected Result:

Submit button on expense preview will not show 0.00 after categorizing expense.

Actual Result:

Submit button on expense preview shows 0.00 after categorizing expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6798965_1744334722232.20250411_092025.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910683588619929607
• Upwork Job ID: 1910683588619929607
• Last Price Increase: 2025-04-11

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit button shows 0 when using table report view.

What is the root cause of that problem?

We always show the amount of the report.

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 632 to 636 in bee2cb5

	{shouldShowSubmitButton && (
	<Button
	success={isWaitingForSubmissionFromCurrentUser}
	text={translate('iou.submitAmount', {amount: getSettlementAmount()})}
	style={buttonMaxWidth}

The amount is 0 because it's a track expense, so the reimbursable spend is 0.

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 254 to 255 in bee2cb5

	return convertToDisplayString(reimbursableSpend, iouReport?.currency);
	};

If we compare it with ReportPreview, we never show the amount for the submit button.

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 665 to 668 in bee2cb5

	{shouldShowSubmitButton && (
	<Button
	success={isWaitingForSubmissionFromCurrentUser}
	text={translate('common.submit')}

What changes do you think we should make in order to solve the problem?

Follow the ReportPreview by not showing the amount.

OR

Return empty string if the amount is 0.

OR

When submitting, I think it makes sense to show even the non reimbursable amount. So, just like here, where we only exclude non-reimbursable for pay action when calculating the non-held amount, we can do the same for getSettlementAmount.

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 156 in bee2cb5

const {nonHeldAmount, fullAmount, hasValidNonHeldAmount} = getNonHeldAndFullAmount(iouReport, shouldShowPayButton);

return convertToDisplayString(shouldShowPayButton ? reimbursableSpend : totalDisplaySpend, iouReport?.currency);

or just use fullAmount

return fullAmount;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If we go with the 2nd solution, we can render MoneyRequestReportPreviewContent and make sure the amount doesn't show if it's 0.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910683588619929607

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[hoangzinh]

Thanks for posting the proposal @bernhardoj. I will try to review it today or tomorrow.

[hoangzinh]

The amount is 0 because it's a track expense, so the reimbursable spend is 0.

Hi @bernhardoj could you help me understand it? I think it's probably a BE issue, when we categorize a track expense, it should set nonReimbursableTotal of iouReport to 0, shouldn't it?

[bernhardoj]

If we categorize a track expense of $5, the nonReimbursableTotal would be -500 because track expense is not reimbursable. The total is also -500.

[hoangzinh]

@bernhardoj I see. I asked experts on Slack, awaiting their thoughts