[$250] Report shows empty state when opening track expense submitted from self DM

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+238029m8@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Account has self DM.
• Account has no workspace

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense in self DM.
4. Click Categorize it.
5. Click Upgrade > Click Got it, thanks.
6. Select a category, enter merchant and submit the expense.
7. Go to Reports.
8. Go to Expense Reports.
9. Click on the submitted expense from Step 6.

Expected Result:

The report will show the track expense submitted from self DM.

Actual Result:

The report does not show the track expense submitted from self DM.
It shows the empty state view.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910692009075279879
• Upwork Job ID: 1910692009075279879
• Last Price Increase: 2025-04-18

Issue Owner

Current Issue Owner: @QichenZhu

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-11 13:21:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense Reports - Report shows empty state when opening track expense submitted from self DM

What is the root cause of that problem?

This happen due to selectTransactionsForReportID selector function

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 113 in e7a9622

selector: (allTransactions): OnyxTypes.Transaction[] => selectTransactionsForReportID(allTransactions, reportID, reportActions),

Here we check transaction.reportID === reportID, but because the transaction.reportID was from selfDm and now that transection in policyExpenseChat so it does not match with reportID

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 95 in e7a9622

return transaction.reportID === reportID && !isDeletedParentAction(action);

What changes do you think we should make in order to solve the problem?

We should get the reportID from parentReportAction.originalMessage?.IOUReportID

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Lines 117 to 120 in e7a9622

	const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${getNonEmptyStringOnyxID(report?.parentReportID)}`, {
	canEvict: false,
	selector: (parentReportActions) => getParentReportAction(parentReportActions, report?.parentReportActionID),
	});

move parentReportAction declaration bellow

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 102 in e7a9622

const {activeWorkspaceID} = useActiveWorkspace();

and update reportID logic like this

    const originalMessage = getOriginalMessage(parentReportAction) as OnyxTypes.OriginalMessageIOU;
    const reportID = originalMessage?.IOUReportID ?? report?.reportID;

so that selectTransactionsForReportID get the correct reportID

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 113 in e7a9622

selector: (allTransactions): OnyxTypes.Transaction[] => selectTransactionsForReportID(allTransactions, reportID, reportActions),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910692009075279879

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[samranahm]

Proposal updated

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense Reports - The Report shows the empty state when opening the track expense submitted from self DM

What is the root cause of that problem?

Since the tracked expense is moved to a policy expense chat, the transaction.reportID will not be equal to report?.reportID.

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 95 in e7a9622

return transaction.reportID === reportID && !isDeletedParentAction(action);

Hence, the transactions array passed the MoneyRequestReportTransactionList component will be empty, and the SearchMoneyRequestReportEmptyState will be displayed.

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Lines 200 to 202 in e7a9622

	<MoneyRequestReportActionsList
	report={report}
	transactions={transactions}

What changes do you think we should make in order to solve the problem?

We should add a check if transaction.reportID == report?.parentReportID is true for this case.

So, we need to replace the reportID argument in the selectTransactionsForReportID function with report: OnyxEntry<OnyxTypes.Report> to get the value of parentReportID.

Then, add the transaction.reportID == report?.parentReportID condition to the selectTransactionsForReportID function.

function selectTransactionsForReportID(transactions: OnyxCollection<OnyxTypes.Transaction>, report: OnyxEntry<OnyxTypes.Report>, reportActions: OnyxTypes.ReportAction[]) {
    ... rest of the function's code
    return Object.values(transactions ?? {}).filter((transaction): transaction is OnyxTypes.Transaction => {
        ... rest of the function's code
        return (transaction.reportID === report?.reportID || transaction.reportID == report?.parentReportID) && !isDeletedParentAction(action);
    });
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should create a test for the selectTransactionsForReportID since there isn't one available.

Then, test it with different types of reports.

What alternative solutions did you explore? (Optional)

N/A