[Due for payment 2025-05-05] Delete switchToOldDotOnNonMicroCompanySize definition and usages

[chiragsalian]

Part of the New Dot Onboarding for 1-50 Companies project

Main issue: https://github.com/Expensify/Expensify/issues/476894
Doc section: https://docs.google.com/document/d/1l1DytMDjRvEwJ7saOiZ3RZ4XjhPmR1kzOz90R0GmHVU/edit?tab=t.0#bookmark=id.q8fer5ih10i
Project: https://github.com/orgs/Expensify/projects/193/views/1

On HOLD till this is live - https://github.com/Expensify/Expensify/issues/490391

As the title says, delete switchToOldDotOnNonMicroCompanySize definition and its usages. Because its logic will be handled in completeGuidedSetup.

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete switchToOldDotOnNonMicroCompanySize definition and usages

What is the root cause of that problem?

Cleanup.

What changes do you think we should make in order to solve the problem?

Straight forward cleanup.
Remove this folder and perform relevant cleanup after https://github.com/Expensify/Expensify/issues/490391 is live and holding PRs are merged.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete switchToOldDotOnNonMicroCompanySize definition and usages

What is the root cause of that problem?

We always call switchToOldDotOnNonMicroCompanySize when pressing continue on CompanySizePage

App/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

Line 78 in b83750a

switchToOldDotOnNonMicroCompanySize(selectedCompanySize);

Then this condition check the onboardingCompanySize and return if its nonMincro

App/src/libs/actions/Welcome/switchToOldDotOnNonMicroCompanySize/index.ts

Line 10 in b83750a

if (onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO) {

What changes do you think we should make in order to solve the problem?

We should remove this

App/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

Line 78 in b83750a

switchToOldDotOnNonMicroCompanySize(selectedCompanySize);

from BaseOnboardingEmployees function and since now we dont need to swich the user anymore delete this directry

and remove export from Welcome/index.ts

App/src/libs/actions/Welcome/index.ts

Line 239 in b83750a

switchToOldDotOnNonMicroCompanySize,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@shawnborton, @CortneyOfstad, @chiragsalian Whoops! This issue is 2 days overdue. Let's get this updated quick!