[Due for payment 2025-05-27] [$250] Attachment - Attachment not found text moves, download modal not shown for broken image

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Slottwo1 in1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Chat Report View

Action Performed:

1. Launch app
2. Open a chat
3. Send a broken image by pasting this text -
   
4. Open the broken image
5. Swipe left & right attachment not found text
6. Note attachment not found text moves
7. Tap download button on top
8. Note download button turns green but no attachment modal displayed.
9. In mweb, open the site
10. Perform step 2 - step 5
11. Note after performing step 2 in mweb, broken image is misaligned and shown in compose box, similarly after performing step 5 in mweb, attachment not found text doesn't move.

Expected Result:

In android, for broken image download button musnt be displayed or attachment not download modal must be shown.
Similarly like mweb, attachment not found must not move.

Actual Result:

In android, attachment not found text moves, download modal not shown for broken image. In mweb, image broken is misaligned and attachment not found text doesn't move.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915486228184113065
• Upwork Job ID: 1915486228184113065
• Last Price Increase: 2025-05-01

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lydiabarclay]

Posted here

[trjExpensify]

👋 @lydiabarclay - I think you should ship this External now, yeah?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915486228184113065

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Attachment - Attachment not found text moves, download modal not shown for broken image

What is the root cause of that problem?

Bug – "Attachment not found" text moves:

• In the following line:
  

  App/src/components/Attachments/AttachmentCarousel/Pager/index.tsx

  Line 140 in ab60cd2

  <AnimatedPagerView

  
  overScrollMode is always set to 'auto', without accounting for cases where there is only one attachment. As a result, the "Attachment not found" view can still be dragged when it shouldn't be.

Bug – Download modal not shown for broken image:

• In this function:
  

  App/src/libs/fileDownload/index.android.ts

  Line 66 in ab60cd2

  fetchedAttachment

  
  if the image is broken, the fetch promise neither resolves nor rejects, preventing the error modal from being triggered.

What changes do you think we should make in order to solve the problem?

Fix Bug Attachment - Attachment not found text moves:

• Update the overScrollMode prop to disable overscroll when there's only one item in the carousel by adding overScrollMode={carouselItems.length > 1 ? 'auto' : 'never'} to:
  

  App/src/components/Attachments/AttachmentCarousel/Pager/index.tsx

  Line 140 in ab60cd2

  <AnimatedPagerView

Fix Bug Download modal not shown for broken image:

• Add a timeout to ensure the fetch promise doesn't hang indefinitely by update:
  

  App/src/libs/fileDownload/index.android.ts

  Line 66 in ab60cd2

  fetchedAttachment

    let didTimeout = false
    const timeoutPromise = new Promise<never>((_, reject) => {
        setTimeout(() => {
            didTimeout = true;
            reject(new Error('timeout'));
        }, 2000);
    });
    Promise.race([fetchedAttachment, timeoutPromise])
  

And update:

App/src/libs/fileDownload/index.android.ts

Lines 92 to 94 in ab60cd2

	.catch(() => {
	showGeneralErrorAlert();
	})

        .catch(() => {
            if(didTimeout){
                fetchedAttachment?.cancel?.()
            }
            showGeneralErrorAlert();
        })

• Note: The timeout and the alert modal can be decided in PR phase.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)