[$250] Expense - The expense preview shows Payer → Requester instead of Requester → Payer.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #60168
Email or phone of affected tester (no customers): applausetester+bm573@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Money Requests

Action Performed:

Precondition -
User A must use Expensifail account.

1. Go to https://staging.new.expensify.co
2. Do a manual request from user A to user B
3. As user A, see the expense preview.

Expected Result:

The expense preview should display the flow as Requester → Payer

Actual Result:

The expense preview displays the flow as Payer → Requester

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021914689021983536203
• Upwork Job ID: 1914689021983536203
• Last Price Increase: 2025-04-22
• Automatic offers:
• nkdengineer | Contributor | 107018080

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - The expense preview shows Payer → Requester instead of Requester → Payer

What is the root cause of that problem?

Let's take a look at these lines

App/src/libs/TransactionPreviewUtils.ts

Lines 46 to 47 in a2b6087

	const fromID = managerID;
	const toID = ownerAccountID;

We are currently always setting fromID as managerID and toID as ownerID, but this is incorrect in this particular case.

What changes do you think we should make in order to solve the problem?

The current code works as expected if it's a pay action

App/src/libs/TransactionPreviewUtils.ts

Lines 46 to 47 in a2b6087

	const fromID = managerID;
	const toID = ownerAccountID;

However, if it's a request action, we need to reverse the roles

This is my suggestion

    let fromID = ownerAccountID;
    let toID = managerID;
    if (type === 'pay') { // we can get type from originalMessage
        fromID = managerID;
        toID = ownerAccountID;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should add unit tests for the getIOUData function to ensure that the from and to fields return the correct values in various scenarios

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021914689021983536203

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[nkdengineer]

Will be fixed here.

[nkdengineer]

@mountiny Please help to assign me here since we will fix it in #60650 and it's not from our regression.