Cleanup any promise chains off of actions inside views

[marcaaron]

Good news here but there really aren't that many cases where we're doing this...

Just gonna kinda break down each one explain what the alternative should be...

Using component state for loading state instead of Onyx

This one is using a loading state locally in a component. Probably, it would be more ideal to find an Onyx key to put that loading state on. But seeing these kind of things does beg the question of where that "loading" state belongs. We've mostly defaulted to putting these on some Onyx key so that's what we should try to do here and move the error handling logic to the action.

App/src/pages/RequestCallPage.js

Lines 100 to 111 in 4e9b6b5

	requestInboxCall(this.props.route.params.taskID, personalPolicy.id, this.state.firstName, this.state.lastName, this.state.phoneNumber)
	.then((result) => {
	this.setState({isLoading: false});
	if (result.jsonCode === 200) {
	Growl.success(this.props.translate('requestCallPage.growlMessageOnSave'));
	fetchOrCreateChatReport([this.props.session.email, CONST.EMAIL.CONCIERGE], true);
	return;
	}
	// Phone number validation is handled by the API
	Growl.error(result.message, 3000);
	});

Another loading issue

App/src/pages/home/report/ReportActionsView.js

Lines 277 to 278 in 4e9b6b5

	fetchActions(this.props.reportID, offset)
	.then(() => this.setState({isLoadingMoreChats: false}));

Chaining actions together that could be combined into a single action and storing errors in component state

This one is a few different actions chained together which seems fine it should just be its own action. The error message should be set somewhere else and not in the component state.

App/src/pages/SetPasswordPage.js

Lines 94 to 111 in 4e9b6b5

	API.ValidateEmail({
	accountID,
	validateCode,
	}).then((responseValidate) => {
	if (responseValidate.jsonCode === 200) {
	API.ChangePassword({
	authToken: responseValidate.authToken,
	password: this.state.password,
	}).then((responsePassword) => {
	if (responsePassword.jsonCode === 200) {
	signIn(this.state.password);
	} else {
	this.setState({
	error: this.props.translate('setPasswordPage.passwordNotSet'),
	});
	}
	});
	} else if (responseValidate.title === CONST.PASSWORD_PAGE.ERROR.ALREADY_VALIDATED) {

Navigation logic

This next two are kind of tricky because I don't think we should have a "navigate" logic added to a generic action that does not navigate when used in other places. But the easy solution is to take this and make it setSecondaryLoginAndNavigate() then refactor later if we need a version that does not navigate

App/src/pages/settings/AddSecondaryLoginPage.js

Lines 78 to 83 in 4e9b6b5

	setSecondaryLogin(this.state.login, this.state.password)
	.then((response) => {
	if (response.jsonCode === 200) {
	Navigation.navigate(ROUTES.SETTINGS_PROFILE);
	}
	});

App/src/pages/settings/PasswordPage.js

Lines 97 to 102 in 4e9b6b5

	changePassword(this.state.currentPassword, this.state.newPassword)
	.then((response) => {
	if (response.jsonCode === 200) {
	Navigation.navigate(ROUTES.SETTINGS);
	}
	});