[Due for payment 2025-06-09] [$250] Reports - App crashes when sending invoice to new user in Reports > Invoices page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): iidsOdsOsdiOdsi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Preconditon:

• Workspace has enabled invoicing feature.

1. Go to staging.new.expensify.com
2. Go to Reports > Invoices.
3. Open FAB > Send invoice.
4. Enter amount > Next.
5. Enter the email of any non-existant Gmail account.
6. Select the account.
7. Click Send invoice.
8. Wait for the app to crash.

Expected Result:

App will not crash when sending invoice to new user in Reports > Invoices page.

Actual Result:

App crashes when sending invoice to new user in Reports > Invoices page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6819339_1746174508072.20250502_161920.mp4

Bug6819339_1746174508079!staging.new.expensify.com-1746174434824.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919262476299363314
• Upwork Job ID: 1919262476299363314
• Last Price Increase: 2025-05-12
• Automatic offers:
• nkdengineer | Contributor | 107286867

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ahmdshrif]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when a user tries to send an invoice to someone who doesn't have an account yet in the Reports > Invoices section.

What is the root cause of that problem?

The TransactionListItemRow.tsx component tries to access accountID property directly from user objects that may be undefined for new users. This causes a TypeError that crashes the app.

What changes do you think we should make in order to solve the problem?

Add null checks when accessing user properties in the TransactionListItemRow component:

• Use optional chaining (?.) when accessing the accountID properties
• Add fallback values (like -1) to ensure valid data is always passed

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. Test the component renders correctly when user objects have missing accountID properties
2. Test the invoice sending flow with non-existent email addresses
3. Test with various combinations of undefined user properties

What alternative solutions did you explore? (Optional)

1. Fixing the data at its source before it reaches the component
2. Using a wrapper component to validate the data
3. Implementing React error boundaries

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919262476299363314

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)