[Due for payment 2025-06-12] [$250] Search - Deleted workspace doesn´t appear as "Archived" on chat preview on "Search"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+653@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Search

Action Performed:

Prerequisite: User has at least two workspaces created.

1. Open the staging.new.expensify.com
2. Tap on "Account" and select "Workspaces"
3. Tap on the three dots icon on any workspace and delete it.
4. Return to inbox.
5. Note that deleted workspace disappeared.
6. Tap on the search icon on the top right corner.
7. Note that deleted workspace is displayed with the word "Archived" next to the name.
   8.Return to "Account" > "Workspaces"
8. Delete another workspace.
9. Return to inbox and tap on the search icon.
10. Note that the deleted workspace doesn´t have the "Archived" label on chat preview.
11. Open the workspace chat.
12. Note that "Archived" label is displayed on header.

Expected Result:

When opening "Search" section after deleting a workspace, the word "Archived" should be displayed at the end of workspace´s name.

Actual Result:

Word "Archived" is not displayed at the end of workspace´s name on chat preview on "Search" after the workspace is deleted. This issue reproduces when deleting more than one workspace.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919798848248177302
• Upwork Job ID: 1919798848248177302
• Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-06 05:54:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Word "Archived" is not displayed at the end of workspace´s name on chat preview on "Search" after the workspace is deleted. This issue reproduces when deleting more than one workspace.

What is the root cause of that problem?

The changedReports is only a partial value of the report. When we delete the WS, the updated value of the workspace's report doesn't have reportID

App/src/components/OptionListContextProvider.tsx

Line 51 in 0601503

const [reports, {sourceValue: changedReports}] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});

Then the updated option of the report isn't correct

App/src/components/OptionListContextProvider.tsx

Lines 102 to 109 in 0601503

	changedReportEntries.forEach((report) => {
	if (!report) {
	return;
	}
	const reportID = report?.reportID;
	const {reportOption} = processReport(report, personalDetails);

What changes do you think we should make in order to solve the problem?

We should get the full value of the changedReports and replace all changedReports in this useEffect with this value

const changedReportsEntries = useMemo(() => {
    const result: OnyxCollection<Report> = {};

    Object.keys(changedReports ?? {}).forEach((key) => {
        const report = reports?.[key];
        if (report) {
            result[key] = report;
        }
    });
    return result;
}, [changedReports, reports]);

If we don't want to add reports as dependency, we can create a ref for reports.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919798848248177302

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mallenexpensify]

@eVoloshchak plz review the proposal above.
@slafortune if the proposal isn't reviewed by the time you see this on Friday, please assign another C+ (cuz it will be 3 days by then). Thx