[Due for payment 2025-06-12] [$250] Expense-Expense without category marked as uncategorized is not shown in reports "no category"

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Sloottwo1 3668@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Login with new Gmail account
3. Tap fab and create new workspace
4. In old dot, login with same account and create a expense without category
5. In new dot, note category displayed as uncategorized
6. Go to reports - filter - no category - view results

Expected Result:

Expense without category marked as uncategorized must be shown in reports "no category" filter.

Actual Result:

Expense without category marked as uncategorized is not shown in reports "no category" filter.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6822803_1746513670047.Screenrecorder-2025-05-06-12-04-30-664.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919855816563816474
• Upwork Job ID: 1919855816563816474
• Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-09 18:30:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense-Expense without category marked as uncategorized is not shown in reports "no category"

What is the root cause of that problem?

When we submit an expense in old dot with out category it store in onyx transaction as category: 'Uncategorized'
on the other hand when we submit an expense on new dot with out category it store as category: '' empty string

for the query category:none we display the expenses with category '' empty only that's why if some expense has category: 'Uncategorized' that does not display in result

What changes do you think we should make in order to solve the problem?

App/src/pages/Search/SearchPage.tsx

Line 78 in f867903

const [lastNonEmptySearchResults, setLastNonEmptySearchResults] = useState<SearchResults | undefined>(undefined);

We should add the category: 'Uncategorized' expenses and adjust our query as category:none,Uncategorized or we can add Uncategorized within category:none

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919855816563816474

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[ijmalik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expenses marked as "Uncategorized" (OD behavior) do not appear under the "No Category" filter (category:none), which currently only matches expenses with an empty category string ('').

What is the root cause of that problem?

Old Dot: Expenses without a category are stored with category: 'Uncategorized'.
New Dot: Expenses without a category use category: '' (empty string).
Query Behavior: The category:none filter only checks for '', ignoring 'Uncategorized' values from OD data.

App/src/pages/Search/SearchPage.tsx

Line 72 in 9586baf

const {q, name} = route.params;

route.params is e.g.
{q: 'sortBy:date sortOrder:desc type:expense status:all category:Car,none'}

For this query, only those records will be return which have category
1- 'Car'
or
2- Empty

So records which are saved with category: 'uncategorized' will not be shown

What changes do you think we should make in order to solve the problem?

{q: 'sortBy:date sortOrder:desc type:expense status:all category:Car,none'}

We should replace none with none,uncategorized in this query string to get the following

{q: 'sortBy:date sortOrder:desc type:expense status:all category:Car,none,uncategorized'}

Code Implementation:
Replace

App/src/pages/Search/SearchPage.tsx

Lines 72 to 74 in 9586baf

	const {q, name} = route.params;
	const queryJSON = useMemo(() => buildSearchQueryJSON(q), [q]);

With

const { q, name } = route.params;  
const queryWithUncategorized = useMemo(() => preprocessSearchQuery(q), [q]);  
const queryJSON = useMemo(() => buildSearchQueryJSON(queryWithUncategorized), [queryWithUncategorized]);  ```

Add a utility function preprocessSearchQuery in src/libs/SearchQueryUtils.ts to handle this transformation

/**
 * Adds 'Uncategorized' to category lists containing 'none'.
 * Handles small query strings efficiently.
 */
const preprocessSearchQuery = (query: string): string => {
  return query
    .split(' ')
    .map((segment) => {
      if (!segment.startsWith('category:')) return segment;

      const [key, ...values] = segment.split(':');
      const categories = values.join(':').split(',');

      if (
        categories.includes('none') && 
        !categories.includes('Uncategorized')
      ) {
        categories.push('Uncategorized');
      }

      return `${key}:${categories.join(',')}`;
    })
    .join(' ');
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test verifying that a query with category:none includes expenses where the category is empty ('') or 'Uncategorized'.

What alternative solutions did you explore? (Optional)

[bradyrose]

Withdrawing this proposal to comply with Expensify’s one-proposal-at-a-time policy.
Hope to circle back if it’s still open later. Thanks!

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).