[Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6069055
Email or phone of affected tester (no customers): applausetester+080506kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has set up Expensify Card with bank account.
• User has assigned themselves or any member a virtual Expensify card.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on the member with Expensify card.
4. Click on the card.
5. Click Deactivate card.
6. Deactivate the card.

Expected Result:

The card will be removed from member profile.

Actual Result:

The card stays in member profile after the card is deactivated.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card stays in member profile after the card is deactivated

What is the root cause of that problem?

Here

https://github.com/Expensify/App/blob/e2c5d7d0f34564e2e5d285d5bcde5a669164fc6c/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx#L374-L376

we did not check if the card is inactive and display all card

What changes do you think we should make in order to solve the problem?

We should explicitly check for inactive card and return null

const inactiveCard = cardList?.[memberCard.cardID];

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.