[$250] android-You appear offline message is displayed above little blank space

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.29-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/466141
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Xiaomi Redmi Note 10S - Android 13, Reliance Jio, Chrome
App Component: LHN

Action Performed:

1. Launch app
2. Go offline
3. Tap fab - start chat - room
4. Tap visibility

Expected Result:

You appear offline message must be displayed at the bottom like mweb.

Actual Result:

You appear offline message is displayed above little blank space.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6805279_1744908175506.Screenrecorder-2025-04-17-21-57-20-996.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021921792507271921322
• Upwork Job ID: 1921792507271921322
• Last Price Increase: 2025-05-12

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-10 17:40:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

You appear offline message is displayed above little blank space

What is the root cause of that problem?

The ValueSelectorModal applies default bottom padding for safe areas, while the ScreenWrapper adds extra padding for the offline indicator when includeSafeAreaPaddingBottom creating double padding that pushes the message up.

What changes do you think we should make in order to solve the problem?

We should add enableEdgeToEdgeBottomSafeAreaPadding = {false}

Here

App/src/components/ValuePicker/ValueSelectorModal.tsx

Lines 34 to 40 in 3c6789a

	<ScreenWrapper
	style={styles.pb0}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom
	testID={ValueSelectorModal.displayName}
	shouldEnableKeyboardAvoidingView={shouldEnableKeyboardAvoidingView}
	>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[kadiealexander]

Android <> iOS bug swap with @jliexpensify

[dubielzyk-expensify]

Yeah this looks like a bug to me. No idea why the background is transparent. On the room screen we don't use a fixed button so the only error to me is the transparent background. The positioning does look right. cc @Expensify/design for gut check

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

android-You appear offline message is displayed above little blank space

What is the root cause of that problem?

We use the ValueSelectorModal component to display the options. This component wraps both a Modal and a ScreenWrapper, each of which adds default bottom padding. This results in extra space at the bottom of the modal.

App/src/components/ValuePicker/ValueSelectorModal.tsx

Lines 24 to 37 in 6feef49

	<Modal
	type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
	isVisible={isVisible}
	onClose={() => onClose?.()}
	onModalHide={onClose}
	hideModalContentWhileAnimating
	useNativeDriver
	onBackdropPress={onBackdropPress}
	shouldHandleNavigationBack
	>
	<ScreenWrapper
	style={styles.pb0}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom

App/src/components/Modal/BaseModal.tsx

Line 312 in 6feef49

style={[styles.defaultModalContainer, modalContainerStyle, modalPaddingStyles, !isVisible && styles.pointerEventsNone]}

What changes do you think we should make in order to solve the problem?

We should update the component to handle edge-to-edge layout correctly. This is important because the modal content can extend beyond the screen height, requiring proper bottom padding handling. The CategorySelectorModal component is a good reference for how this should be done.
Required Changes:

• Add enableEdgeToEdgeBottomSafeAreaPadding to both Modal and ScreenWrapper:
  

  App/src/components/ValuePicker/ValueSelectorModal.tsx

  Lines 32 to 34 in 6feef49

  	shouldHandleNavigationBack
  	>
  	<ScreenWrapper

 <Modal
enableEdgeToEdgeBottomSafeAreaPadding
...>
            <ScreenWrapper
                enableEdgeToEdgeBottomSafeAreaPadding

• Pass addBottomSafeAreaPadding down to ValueSelectionList, and then to SelectionList:
  

  App/src/components/ValuePicker/ValueSelectorModal.tsx

  Line 45 in 6feef49

  <ValueSelectionList

                <ValueSelectionList
                addBottomSafeAreaPadding

App/src/components/ValuePicker/ValueSelectionList.tsx

Lines 12 to 13 in 6feef49

	return (
	<SelectionList

        <SelectionList
            addBottomSafeAreaPadding={addBottomSafeAreaPadding}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We only need to pass enableEdgeToEdgeBottomSafeAreaPadding to the Modal component

App/src/components/ValuePicker/ValueSelectorModal.tsx

Line 24 in 6feef49

<Modal

        <Modal
        enableEdgeToEdgeBottomSafeAreaPadding

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021921792507271921322