[Due for payment 2025-06-12] [$250] Hybrid - Native Share - Can share a photo or video to a deleted Workspace

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6118742
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 12 / iOS 17.7.2
App Component: Chat Report View

Action Performed:

Precondition: Log in to the app and have a deleted Workspace

1. Open the Gallery on the phone
2. Select a photo or video and share it with the app
3. Select the deleted Workspace
4. Enter a message or not
5. Tap on the Share button

Expected Result:

The deleted Workspace should not display on the share screen

Actual Result:

The user can share with a deleted Workspace, and it displays an error message and which does not translate to Spanish

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6833035_1747390681876.deleted_WS_share.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021924890020757248650
• Upwork Job ID: 1924890020757248650
• Last Price Increase: 2025-05-20
• Automatic offers:
• mkzie2 | Contributor | 107428105

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can share with a deleted Workspace, and it displays an error message and which does not translate to Spanish

What is the root cause of that problem?

We get search options using getSearchOptions

App/src/pages/Share/ShareTab.tsx

Line 48 in cd0fae3

return getSearchOptions(options, betas ?? [], false);

Currently, there's no logic to filter out archived workspace chat (a.k.a read-only chat), so the archived WS chat report is shown. This is because includeReadOnly defaults to true

App/src/libs/OptionsListUtils.ts

Line 1443 in cd0fae3

includeReadOnly = true,

What changes do you think we should make in order to solve the problem?

We should add includeReadOnly to getSearchOptions, defaults to true. Then pass it to getValidOptions

App/src/libs/OptionsListUtils.ts

Line 1811 in e4f62dd

const optionList = getValidOptions(options, {

Set includeReadOnly as false in ShareTab

App/src/pages/Share/ShareTab.tsx

Line 48 in cd0fae3

return getSearchOptions(options, betas ?? [], false);

return getSearchOptions(options, betas ?? [], false, false);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021924890020757248650

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Pujan92]

@mkzie2's proposal looks good to me where we need to filter out read-only chats.

🎀👀🎀 C+ reviewed