[Due for payment 2025-07-23] [$250] Magic code not sent on first attempt when revealing virtual card details

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.46-11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to Accounts > Wallet
2. Click on any assigned existing virtual card
3. Click on Reveal details
4. Wait for the magic code to arrive

Expected Result:

The magic code should be sent immediately upon the first attempt to reveal virtual card details.

Actual Result:

The code is not sent on the first attempt and only works after the resend.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2025-05-19_08-24-04.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021924934153177103110
• Upwork Job ID: 1924934153177103110
• Last Price Increase: 2025-06-10
• Automatic offers:
• thelullabyy | Contributor | 107627924

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The validation code is not sent on the first attempt when accessing the card page; it only works after the user clicks "Resend."

What is the root cause of that problem?

• In ExpensifyCardPage, we use the ValidateCodeActionModal component.
• This component only requests a new validation code if validateCodeAction?.validateCodeSent is false.
• On the first click of "Reveal details," the validation code is sent correctly and validateCodeAction?.validateCodeSent is set to true.
• However, there is currently no logic to reset validateCodeAction?.validateCodeSent to false.
• As a result, if a user navigates to another card page and clicks "Reveal details," the validation code is not requested again.

What changes do you think we should make in order to solve the problem?

• To ensure a validation code is always sent on the first interaction after navigating to a card page, we can reset the validateCodeSent flag on component mount.
• This can be done by adding the following effect to ExpensifyCardPage.tsx:

useEffect(() => {
    resetValidateActionCodeSent();
}, []);

• This ensures that validateCodeAction?.validateCodeSent is reset to false every time the page is visited, allowing the code to be sent properly on the first attempt.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021924934153177103110

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[eVoloshchak]

@thelullabyy, I agree with your evaluation of the root cause (#62326 (comment)).

However, I wonder if there a more universal approach? You're proposing to clear the validateCodeSent flag every time ExpensifyCardPage is opened, which means the same bug will be present if we ever add a new page that needs the user to re-authenticate with a magic code. Could we reset the flag somewhere in ValidateCodeActionModal component? Or after a successful sign-in?

[thelullabyy]

@eVoloshchak

However, I wonder if there a more universal approach

I saw that the logic "clearing the validateCodeSent flag every time opens the page" is also applied in other pages such as App/src/pages/settings/Wallet/ReportCardLostPage.tsx

which means the same bug will be present if we ever add a new page that needs the user to re-authenticate with a magic code

Sorry, could you clarify what you mean here?

Could we reset the flag somewhere in ValidateCodeActionModal component? Or after a successful sign-in?

I don’t think resetting the flag after a successful validate code is viable. Here's why: imagine the user initiates a "reveal virtual card" action on the first card—this sets the flag to true, indicating a magic code has been sent. But then they don’t complete the authentication flow. Instead, they open a second card and try to reveal it. Since the flag is still true, no new magic code gets sent.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸