[Due for payment 2025-07-17] [$250] WS - Not here page appears when trying to navigate to Workspaces.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): biruknew45+295llk@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. As user A, create a workspace and add user B as a member
3. As user B, click on Workspaces > click on the WS created by user A then navigate back to inbox
4. As user A, delete the workspace
5. AS user B, click on Workspaces

Expected Result:

Not here page shouldn't appear. After the workspace is deleted, it should navigate to the Workspaces page instead.

Actual Result:

Not here page appears when trying to navigate to Workspaces after admin deletes the WS

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925558315243155829
• Upwork Job ID: 1925558315243155829
• Last Price Increase: 2025-05-22
• Automatic offers:
• QichenZhu | Reviewer | 107412026
• Krishna2323 | Contributor | 107412029

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925558315243155829

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[Krishna2323]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 14:57:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS - Not here page appears when trying to navigate to Workspaces.

What is the root cause of that problem?

• Before navigating to the last accessed policy, we are not checking if the policy should be shown or not:
  

  App/src/components/Navigation/NavigationTabBar/index.tsx

  Lines 180 to 196 in 80ecb73

  	// If there is a workspace navigator route, then we should open the workspace initial screen as it should be "remembered".
  	if (lastWorkspacesTabNavigatorRoute.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
  	const params = workspacesTabState?.routes.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];
  	// Screens of this navigator should always have policyID
  	if (params.policyID) {
  	const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
  	// This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
  	navigationRef.dispatch({
  	type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
  	payload: {
  	policyID: params.policyID,
  	screenName: workspaceScreenName,
  	},
  	});
  	}
  	return;
  	}

What changes do you think we should make in order to solve the problem?

• We should check the policy existence before navigating to the last accessed policy or policy page:

            // If there is a workspace navigator route, then we should open the workspace initial screen as it should be "remembered".
            if (lastWorkspacesTabNavigatorRoute.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
                const params = workspacesTabState?.routes.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];
                // Screens of this navigator should always have policyID
                const policy = getPolicy(params.policyID);
                const shouldShowsPolicy = shouldShowPolicy(policy, false, currentUserLogin);
                const isPendingDelete = isPendingDeletePolicy(policy);

                if (!shouldShowsPolicy || isPendingDelete) {
                    Navigation.navigate(ROUTES.WORKSPACE_HUB_INITIAL);
                    return;
                }

                if (params.policyID) {
                    const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
                    // This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
                    navigationRef.dispatch({
                        type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
                        payload: {
                            policyID: params.policyID,
                            screenName: workspaceScreenName,
                        },
                    });
                }
                return;
            }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

[neil-marcellini]

@Krishna2323's proposal LGTM

Can we also put this logic into an action function and write a unit test for it please?