[C+ Checklist Needs Completion] [$125] mWeb - Expense - Tapping more, in bottom modal "view details" option is partially hidden.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9 1.49-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Applausetester lq@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with a expensifail account
3. Open a new workspace chat
4. Create a manual expense entering merchant
5. Open the expense details page
6. Turn off internet (wait till turn off internet shown on top)
7. Tap more dropdown

Expected Result:

Tapping more, in bottom modal "view details" option must not be partially hidden.

Actual Result:

Tapping more, in bottom modal "view details" option is partially hidden.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927398093927514965
• Upwork Job ID: 1927398093927514965
• Last Price Increase: 2025-06-04
• Automatic offers:
• nkdengineer | Contributor | 107530524

Issue Owner

Current Issue Owner: @greg-schroeder

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Expense - Tapping more, in bottom modal "view details" option is partially hidden.

What is the root cause of that problem?

On the case on OP there are 8 action items, which the hight of the popover not enough for all. And we don't implement scrolling

What changes do you think we should make in order to solve the problem?

add shouldUseScrollView here

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 213 to 240 in 413eb10

	{(shouldAlwaysShowDropdownMenu || options.length > 1) && !!popoverAnchorPosition && (
	<PopoverMenu
	isVisible={isMenuVisible}
	onClose={() => {
	setIsMenuVisible(false);
	onOptionsMenuHide?.();
	}}
	onModalShow={onOptionsMenuShow}
	onItemSelected={() => setIsMenuVisible(false)}
	anchorPosition={shouldUseStyleUtilityForAnchorPosition ? styles.popoverButtonDropdownMenuOffset(windowWidth) : popoverAnchorPosition}
	shouldShowSelectedItemCheck={shouldShowSelectedItemCheck}
	// eslint-disable-next-line react-compiler/react-compiler
	anchorRef={nullCheckRef(dropdownAnchor)}
	withoutOverlay
	anchorAlignment={anchorAlignment}
	headerText={menuHeaderText}
	menuItems={options.map((item, index) => ({
	...item,
	onSelected: item.onSelected
	? () => item.onSelected?.()
	: () => {
	onOptionSelected?.(item);
	setSelectedItemIndex(index);
	},
	shouldCallAfterModalHide: true,
	}))}
	/>
	)}

                <PopoverMenu
                    ...
                    shouldUseScrollView
                />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-02 10:25:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping more, in bottom modal "view details" option is partially hidden.

What is the root cause of that problem?

in default, we set max height for the popover menu here

App/src/components/PopoverMenu.tsx

Lines 141 to 142 in 413eb10

	/** Whether we should set a max height to the popover content */
	shouldEnableMaxHeight?: boolean;

App/src/components/PopoverMenu.tsx

Lines 381 to 386 in 413eb10

	const menuContainerStyle = useMemo(() => {
	if (isSmallScreenWidth) {
	return shouldEnableMaxHeight ? {maxHeight: windowHeight - 250} : {};
	}
	return styles.createMenuContainer;
	}, [isSmallScreenWidth, shouldEnableMaxHeight, windowHeight, styles.createMenuContainer]);

and as in OP we have 8 items it leads to maxHeight not enough for all.

What changes do you think we should make in order to solve the problem?

1. We should add shouldUseScrollView props to make this list scrollable

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 214 to 218 in 413eb10

	<PopoverMenu
	isVisible={isMenuVisible}
	onClose={() => {
	setIsMenuVisible(false);
	onOptionsMenuHide?.();

we actually want the top padding part to scroll with the content, not to cut it off.

2. We should add shouldUseModalPaddingStyle as false and scrollContainerStyle={styles.pv4}

    <PopoverMenu
        scrollContainerStyle={styles.pv4}
        shouldUseModalPaddingStyle={false}
    ...
    />

shouldUseModalPaddingStyle to remove padding vertical in here

App/src/components/Modal/BaseModal.tsx

Line 231 in 413eb10

return shouldUseModalPaddingStyle ? paddings : {paddingLeft: paddings.paddingLeft, paddingRight: paddings.paddingRight};

3. We also need to remove padding vertical in modalContainerStyle if shouldUseModalPaddingStyle is false in here

App/src/styles/utils/generators/ModalStyleUtils.ts

Lines 215 to 216 in 413eb10

	paddingTop: variables.componentBorderRadiusLarge,
	paddingBottom: variables.componentBorderRadiusLarge,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

• Or we can change max height calculation here

App/src/components/PopoverMenu.tsx

Lines 381 to 386 in 413eb10

	const menuContainerStyle = useMemo(() => {
	if (isSmallScreenWidth) {
	return shouldEnableMaxHeight ? {maxHeight: windowHeight - 250} : {};
	}
	return styles.createMenuContainer;
	}, [isSmallScreenWidth, shouldEnableMaxHeight, windowHeight, styles.createMenuContainer]);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927398093927514965

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

Thank you for your proposals!

I think @nyomanjyotisa 's idea to fix issue with shouldUseScrollView is good to go with.