[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Expense- After deleting an expense with all expenses selected, dropdown button does not update

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+2e89295@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit three expenses to workspace chat
4. Click on the expense preview
5. Select all expenses via checkbox
6. Click on one of the expenses
7. Click More > Delete
8. Delete the expense

Expected Result:

Dropdown button will change to "2 selected"

Actual Result:

Dropdown button is still showing "3 selected"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6839241_1747924988859.20250522_223819.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928050904853691931
• Upwork Job ID: 1928050904853691931
• Last Price Increase: 2025-05-29
• Automatic offers:
• FitseTLT | Contributor | 107535515

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 15:00:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense- After deleting an expense with all expenses selected, dropdown button does not update

What is the root cause of that problem?

We forgot to call removeTransaction after deleting request here

App/src/components/MoneyRequestHeader.tsx

Line 322 in 413eb10

deleteMoneyRequest(transaction?.transactionID, parentReportAction);

What changes do you think we should make in order to solve the problem?

We need to call removeTransaction after deleting request just like we do in report details page

App/src/pages/ReportDetailsPage.tsx

Lines 927 to 928 in 413eb10

	deleteMoneyRequest(iouTransactionID, requestParentReportAction, isSingleTransactionView);
	removeTransaction(iouTransactionID);

    const {removeTransaction} = useMoneyRequestReportContext();
...

                    removeTransaction(transaction.transactionID);

We can do the same in other places we deleteRequest where needed or we can also take the clearing logic inside deleteMoneyRequest for general fix.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[dylanexpensify]

reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928050904853691931

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[kory-smith]

Hi! Long-time listener, first-time caller here.

Restating the problem

When a user Selects All expenses, deletes one, and returns to the list, the bulk-action dropdown still reads “3 selected” instead of “2 selected.”

Root cause

MoneyRequestHeader.tsx calls

deleteMoneyRequest(transactionID, parentReportAction);

but never follows up with removeTransaction().
Without that local-store cleanup, the MoneyRequestReportContext keeps the deleted ID in selectedTransactionsID, so the counter never re-renders.

Proposed technical changes

1. MoneyRequestHeader.tsx

   • Extend context destructuring:

     const {selectedTransactionsID, setSelectedTransactionsID, removeTransaction} = useMoneyRequestReportContext();

   • Immediately after deleteMoneyRequest, add

     removeTransaction(transaction.transactionID);

   • Remove any duplicate useMoneyRequestReportContext() lines to avoid redeclaration errors.

2. PopoverReportActionContextMenu.tsx (long-press / context-menu flow)

   • After each deleteMoneyRequest or deleteTrackExpense call, invoke

     removeTransaction(originalMessage?.IOUTransactionID);

   This keeps selection state in sync no matter how the user deletes.

Automated-test coverage to prevent regressions

• E2E (Detox) – “Create 3 expenses → Select All → Delete first → Expect dropdown to read ‘2 selected.’”
  Runs on Android, iOS, Desktop, Web, and Mobile Web.
• Unit test – Assert removeTransaction is invoked when deleteMoneyRequest resolves in MoneyRequestHeader.