[Due for payment 2025-06-05] [Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): applausetester+mentiont1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Money Requests

Action Performed:

1. Start a chat with a new user
2. Submit two manual expenses
3. Open the combined expense report
4. Click on More button > Click on Delete > Click on Delete on confirmation modal
5. Open one of the expenses that were deleted on step 4 and is moved to personal expenses
6. Open the expense detail > click on the report header > submit it to someone
7. Select the same user you have started chat with on step 1
8. Click Create expense

Expected Result:

Expense should be submitted to the user

Actual Result:

Unending spinner is displayed on submit button

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6840601_1748031983677.Screen_Recording_2025-05-23_at_11.09.11_at_night.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unending spinner when submitting an expense to a user.

What is the root cause of that problem?

There is an endless spinner because when we request money we need linkedTrackedExpenseReportAction:

App/src/libs/actions/IOU.ts

Lines 5195 to 5200 in 526a0e4

	switch (action) {
	case CONST.IOU.ACTION.SUBMIT: {
	if (!linkedTrackedExpenseReportAction || !linkedTrackedExpenseReportID) {
	return;
	}
	const workspaceParams =

which is missing when expenses deleted from a report are transferred in selfDM, this causes us to return early and the endless spinner is present because when we get linkedTrackedExpenseReportAction in createDraftTransactionAndNavigateToParticipantSelector while submitting an expense:

App/src/libs/ReportUtils.ts

Lines 9592 to 9594 in 526a0e4

	const linkedTrackedExpenseReportAction = Object.values(reportActions)
	.filter(Boolean)
	.find((action) => isMoneyRequestAction(action) && getOriginalMessage(action)?.IOUTransactionID === transactionID);

This will return none as there is no IOU report action for that report created and also we don't have it's IOUTransactionID.
This is the RCA.

What changes do you think we should make in order to solve the problem?

When deleting the report, we should optimistically add the actionName and IOUTransactionID here:

App/src/libs/actions/Report.ts

Lines 4772 to 4781 in 526a0e4

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
	value: {
	[newReportActionID]: {
	originalMessage: {
	movedToReportID: selfDMReportID,
	},
	},
	},
	},

optimisticData.push(
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${childReportID}`,
                value: {
                    parentReportActionID: newReportActionID,
                    parentReportID: selfDMReportID,
                    chatReportID: selfDMReportID,
                    policyID: CONST.POLICY.ID_FAKE,
                },
            },
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
                value: {
                    [newReportActionID]: {
                        actionName: CONST.REPORT.ACTIONS.TYPE.IOU,
                        originalMessage: {
                            IOUTransactionID: transactionID,
                            movedToReportID: selfDMReportID,
                        },
                    },
                },
            },
        );

Result video:

Screen.Recording.2025-05-25.at.3.25.51.AM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A