Reports - Selecting the Approve filter, reports with pay action pending are shown

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61170
Email or phone of affected tester (no customers): applausetester+ag2305.5@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 14
App Component: Search

Action Performed:

Pre-conditions:
Have reports with pending approval in a workspace and IOU requests with pending payment.
Use an Expensifail account that is a workspace admin.

1. Go to staging.new.expensify.com
2. Log in as workspace admin
3. Go to the Reports tab
4. Click on the Approve option from the LHN

Expected Result:

Only reports awaiting approval should be displayed.

Actual Result:

Reports awaiting approval and IOU requests awaiting payment are displayed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[BlameGPT]

Possible culprit PRs for this issue

• Suggested Search & Filter Revamp #61170: This PR modifies the filter functionality in the sidebar, which could directly affect how reports are displayed when filtering by the Approve option, potentially showing both reports awaiting approval and IOU requests awaiting payment incorrectly.
• Adjust copy for various report actions #60171: This PR involves approving expenses in a workspace context, which may impact display logic and copy regarding approval statuses, relating to how reports are filtered under the Approve option.
• Disabling report fields for non admin when report is approved. #61726: This PR introduces a condition to disable report fields for non-admins when reports are approved. This change may alter the filtering logic and visibility of pending reports.

Please 👍 or 👎