[Due for payment 2025-06-12] [$250] "Edit Per Diem Rate" Back Button Redirects to Workspace instead of Expense Creation Flow

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exporatory
Email or phone of affected tester (no customers): applausetester+dp93@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Xiaomi Poco X4 / Android 13
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in.
2. Create a workspace
3. Activate Per Diem in Workflow (make sure you don't have per diem data uploaded yet)
4. Go to inbox, workspace chat
5. Tap + -> Create Expense
6. Select Per diem in top right corner
7. Tap "Edit per diem rates" button
8. Tap Back button in top left corner

Expected Result:

Clicking the Back button should return the user to the Expense Creation menu so they can choose the type of expense to report.

Actual Result:

Clicking the Back button takes the user to Workspace Settings.
Android, repro in Web but issue is not that obvious on Web because of different UI

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6843085_1748298448009.video_2025-05-26_15-27-01.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928580634664491215
• Upwork Job ID: 1928580634664491215
• Last Price Increase: 2025-05-30
• Automatic offers:
• nkdengineer | Contributor | 107533992

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-27 07:49:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking the Back button takes the user to Workspace Settings.
Android, repro in Web but issue is not that obvious on Web because of different UI

What is the root cause of that problem?

We don't add back to to here

App/src/pages/iou/request/step/IOURequestStepDestination.tsx

Lines 144 to 148 in 9401610

	onPress={() => {
	InteractionManager.runAfterInteractions(() => {
	Navigation.navigate(ROUTES.WORKSPACE_PER_DIEM.getRoute(policy.id));
	});
	}}

What changes do you think we should make in order to solve the problem?

We should add backTo to route WORKSPACE_PER_DIEM and pass it as Navigation.getActiveRoute()

    WORKSPACE_PER_DIEM: {
        route: 'settings/workspaces/:policyID/per-diem',
        getRoute: (policyID: string | undefined, backTo?: string) => {
            if (!policyID) {
                Log.warn('Invalid policyID is used to build the WORKSPACE_PER_DIEM route');
            }
            return getUrlWithBackToParam(`settings/workspaces/${policyID}/per-diem`, backTo);
        },
    },

      onPress={() => {
          InteractionManager.runAfterInteractions(() => {
              Navigation.navigate(ROUTES.WORKSPACE_PER_DIEM.getRoute(policy.id, Navigation.getActiveRoute()));
          });
      }}

we have handled backTo in headerWithBackButton here

App/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Lines 386 to 399 in 9401610

	onBackButtonPress={() => {
	if (selectionMode?.isEnabled) {
	setSelectedPerDiem([]);
	turnOffMobileSelectionMode();
	return;
	}
	if (backTo) {
	Navigation.goBack(backTo);
	return;
	}
	Navigation.popToSidebar();
	}}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928580634664491215

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

@nkdengineer's proposal looks good.

🎀 👀 🎀 C+ review

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.