[Due for payment 2025-07-01] [$250] Per diem - App restarts per diem expense creation flow after clicking Save on subrate page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sniodjdsoisjdo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create report.
4. Click Add expense button on the expense preview.
5. Click Create new expense.
6. Switch to Per diem.
7. Select a destination.
8. Select time and date > Save.
9. Select subrate and enter quantity.
10. Click Save on subrate page.

Expected Result:

App will proceed to confirmation page.

Actual Result:

App restarts per diem expense creation flow after clicking Save on subrate page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6846026_1748558387625.20250530_063137.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929345987036305615
• Upwork Job ID: 1929345987036305615
• Last Price Increase: 2025-06-02
• Automatic offers:
• brunovjk | Reviewer | 107607279
• mkzie2 | Contributor | 107607280

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App restarts per diem expense creation flow after clicking Save on subrate page.

What is the root cause of that problem?

The transaction is initialized with reportID pointing to the newly created report (not the workspace report). But the reportID from URL points to the workspace report, because we initialized the flow from the workspace report.

In this line, after selecting the country, we set the reportID in URL to the workspace report:

App/src/pages/iou/request/step/IOURequestStepDestination.tsx

Lines 95 to 96 in f09bb6d

	} else if (explicitPolicyID) {
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_TIME.getRoute(action, iouType, transactionID, policyExpenseReport?.reportID ?? reportID));

That logic is to make sure after we confirm the expense creation, we don't automatically open the expense report, but stay in the workspace report.

Because the transaction.reportID does not match the reportID from URL, we call startMoneyRequest and go back to the first step in the flow (the country step):

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 252 to 261 in fa2cb85

	if (
	transaction?.transactionID &&
	(!transaction?.isFromGlobalCreate || !isEmptyObject(transaction?.participants)) &&
	(isCurrentReportID || isMovingTransactionFromTrackExpense || iouType === CONST.IOU.TYPE.INVOICE)
	) {
	return;
	}
	startMoneyRequest(
	CONST.IOU.TYPE.CREATE,

What changes do you think we should make in order to solve the problem?

We should remove this logic:

App/src/pages/iou/request/step/IOURequestStepDestination.tsx

Lines 95 to 96 in f09bb6d

	} else if (explicitPolicyID) {
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_TIME.getRoute(action, iouType, transactionID, policyExpenseReport?.reportID ?? reportID));

so the reportID in URL always points to the report that the expense to be create would belong to.

Instead, to make sure this logic still works:

That logic is to make sure after we confirm the expense creation, we don't automatically open the expense report, but stay in the workspace report.

We need to implement backToReport URL param for all the per diem steps, and specify it as the current workspace report so after completing the expense creation, we stay in the workspace report. Just like what we did with other types of expense in this PR #61760:

App/src/ROUTES.ts

Lines 911 to 915 in f09bb6d

	MONEY_REQUEST_CREATE_TAB_MANUAL: {
	route: ':action/:iouType/start/:transactionID/:reportID/manual/:backToReport?',
	getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string, backToReport?: string) =>
	`${action as string}/${iouType as string}/start/${transactionID}/${reportID}/manual/${backToReport ?? ''}` as const,
	},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Add another exception in this logic so that we won't trigger startMoneyRequest if requestType is per diem:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 252 to 258 in fa2cb85

	if (
	transaction?.transactionID &&
	(!transaction?.isFromGlobalCreate || !isEmptyObject(transaction?.participants)) &&
	(isCurrentReportID || isMovingTransactionFromTrackExpense || iouType === CONST.IOU.TYPE.INVOICE)
	) {
	return;
	}

[VictoriaExpensify]

Yeah we should fix this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929345987036305615

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

I think we can go with @mkzie2's proposal. Thanks.

🎀👀🎀 C+ reviewed