Hold expense - Unable to hold expense via checkbox if the expense thread is not opened first

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6206790
Email or phone of affected tester (no customers): sdjosdinjsdodinsj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace chat.
4. Submit two expenses.
5. Click on the expense preview to go to expense report.
6. Do not open any expense.
7. Select any expense via checkbox.
8. Click More > Hold.
9. Enter reason and save it.
10. The expense is still not held.
11. Click on the same expense row then close it.
12. Click More > Hold.
13. Enter reason and save it.
14. Now the expense is held, only after the expense is opened.

Expected Result:

In Step 10, the expense will be held via checkbox and More option when the expense thread is not opened previously.

Actual Result:

In Step 10, the expense cannot be held via checkbox and More option when the expense thread is not opened previously.
In Step 14, the expense can only be held after the expense thread is opened at least once.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6850975_1749073662390.20250605_054327.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[BlameGPT]

Possible culprit PRs for this issue

• [Better Expense Report View] Generalise SearchContext + #61777 follow-up #62472: The PR's test steps and files changed directly relate to holding expenses via checkbox and More option, matching the issue reproduction flow.
• Stop creating the transaction thread reports optimistically for RequestMoney #62080: This PR modifies core components and logic related to expense threads and reports, which aligns with the issue where holding an expense depends on opening the expense thread.
• fix: RBR Hold Message #63129: This PR addresses holding expenses and related messaging, which is semantically similar and could affect holding expense behavior.