Ensure the tryNewDot NVP is applied during account reopening

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6208647
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.4.1
App Component: Other

Action Performed:

1. Sign in to the HybridApp with the validated gmail account that has tryNewdot.classicRedirect.dismissed:false
2. Navigate to the Account - Security - Close account
3. Enter a default contact method and tap "Close account" button
4. On the Sign in page type the email address for the just closed account, tap "Reopen"
5. Sign in with the magic code link

Expected Result:

The app opens on the NewDot experience

Actual Result:

The user is signed in to Classic (OldApp).

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6850956_1749072539750.Closed.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

This is two completely separate issues actually.

Issue 1

After a user closes their account, if they try signing back in to reopen their account, we don't send a magic link (if they try a second time, it works).

• This would fall under the Quality project.
• I also noticed that after trying to sign in the first time, we go back to the sign in options page, but the second time, we take the user to a

Issue 2

After closing and reopening your account (with a public email), the user is taken to Classic with no option to switch to NewDot

• This one falls under the Migrate project
• I was talking with @Julesssss about this and we have a theory. We think that when the user closes their account, all their NVPs are stripped from their account (including tryNewDot). Then, when the reopen their account, we don't add the tryNewDot NVP back like we would during the process of initially creating the account.

cc @Julesssss @trjExpensify - it may make sense to create another issue for this one, but I figured we could discuss first.

[sakluger]

We discussed in Slack, and we're going to keep this GH issue for the OldDot/NewDot issue. I've split off the magic link bug into a separate GH issue.

@trjExpensify made a good point in Slack. If some NVPs remain when closing a user's account, then including tryNewDot in the list of NVPs that remain would be the easiest option. Otherwise, we should treat reopened accounts like new accounts and put them in the NewDot experience like all other first-time mobile users.

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sakluger]

The Slack discussion is continuing - we are discussing how we want to solve it.