Profile - Unable to add symbols or spaces when adding phone number as secondary login

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #6293

Action Performed:

1. Navigate to NewDot and login
2. Go to settings > profile
3. Tap add phone number
4. Input a phone number using any of symbols -, (, ) or spaces (e.g. +1 (222) 222 2222)

Expected Result:

User able to add phone number with symbols without any error

Actual Result:

Unable to add symbols, tapping symbols in key board does nothing

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Issue was found when executing #6293

Bug5341121_number.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Not a deploy blocker.
Unfortunately, this was neither added to the to-do list of the issue nor discussed in the PR review. So I missed it.

---

To fix this,

1. We need to add the same logic as requestCallPage to the AddSecondaryLoginPage.
   a. It involves allowing special chars in the phone input.
   b. Validating the input with these chars.
   c. sanitizing the input before sending it to it backend.
2. Apart from it, we are using Phone_pad keyboard for native devices so it won't be possible to allow brackets there. let me know what should be done about it.

[parasharrajat]

Unfortunately, this was neither added to the to-do list of the issue nor discussed in the PR review. So I missed it.

Due to this, I don't consider it now as part of the original issue. But I would like to fix this, let me know if I can submit a PR asap.

[chiragsalian]

For sure, go ahead and create and submit a PR @parasharrajat.

[MelvinBot]

📣 @parasharrajat You have been assigned to this job by @chiragsalian!
Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

Apart from it, we are using Phone_pad keyboard for native devices so it won't be possible to allow brackets there.

let me know what should be done about it.

[chiragsalian]

Thats fine that we don't show brackets for native devices. Thanks for working on the issue rajat.

[chiragsalian]

I totally missed noticing we had phone input in AddSecondaryLoginPage as well.