Chat - Empty chat will show a pronoun placeholder

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #4921

Action Performed:

1. Open app and login
2. Start a conversation with someone never messaged before, with a contact who has setup their desired pronoun

Expected Result:

"Be the first person to comment!" new screen shown without any issues

Actual Result:

New message shows a pronoun placeholder string in the end

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: No (New feature)
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Issue was found when executing #4921

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MirFahad58]

as we discussed in the issue for that if there are any pronouns we should show and also it is in Figma design

https://www.figma.com/file/rReWxiEhGDHIjajsE9XoJw/Start-a-Chat?node-id=0%3A1

[Gonals]

On it

[parasharrajat]

Do you mind if I propose a fix? @Gonals

1. We recently made a change to localize the pronouns.
2. But the PR introducing this feature, did not have conflicts as this is a data change instead of code.
3. Now, backend store prefixed strings for pronouns instead of real value.
4. We have to use

   if (pronouns && pronouns.startsWith(CONST.PRONOUNS.PREFIX)) {
        const localeKey = pronouns.replace(CONST.PRONOUNS.PREFIX, '');
        pronouns = props.translate(`pronouns.${localeKey}`);
    }

instead of

App/src/components/ReportWelcomeText.js

Line 59 in c95c2dd

pronouns,

.
Thus it would use the real value on the UI

App/src/components/ReportWelcomeText.js

Line 82 in c95c2dd

{!_.isEmpty(pronouns) && <Text>{` (${pronouns})`}</Text>}

.

This will fix it.