[Due for payment 2025-07-18] [$250] Fix `isOneTransactionReport`

[grgia]

Problem

/**
 * Checks if a report has only one transaction associated with it
 */
function isOneTransactionReport(report: OnyxEntry<Report>): boolean {
    const reportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.reportID}`] ?? ([] as ReportAction[]);
    const chatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`];
    return getOneTransactionThreadReportID(report, chatReport, reportActions) !== null;
}

getOneTransactionThreadReportID never returns null, it returns undefined. Therefore, this function ALWAYS RETURNS TRUE.

However, There's a load of icon/search logic using this function incorrectly. I can't just update the line without breaking things

Solution

    return getOneTransactionThreadReportID(report, chatReport, reportActions) !== undefined;

Ensure there are no regressions from this change

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021935157794186843039
• Upwork Job ID: 1935157794186843039
• Last Price Increase: 2025-06-18

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

Pinged @JakubKorytko here https://expensify.slack.com/archives/C08CZDJFJ77/p1750173049004479 as OG author

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The isOneTransactionReport function always returns true because it checks against null, but getOneTransactionThreadReportID returns undefined when no transaction is found.

What is the root cause of that problem?

The condition getOneTransactionThreadReportID(...) !== null is incorrect because the function never returns null—only undefined. As a result, the check always evaluates to true, leading to incorrect assumptions in logic dependent on this function.

What changes do you think we should make in order to solve the problem?

We should update the condition to:

return getOneTransactionThreadReportID(report, chatReport, reportActions) !== undefined;

This accurately reflects the function's return behavior and prevents misidentifying reports as single-transaction when they are not.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Although no new tests are proposed now, we should verify:

• Reports with no associated transactions return false.
• Reports with one transaction return true.
• Existing UI behaviors depending on this logic (e.g., icon/search visibility) are not broken.

What alternative solutions did you explore? (Optional)

None. The solution is straightforward—a type-correct comparison that aligns with the actual return value of the helper function.

[JakubKorytko]

getOneTransactionThreadReportID never returns null, it returns undefined. Therefore, this function ALWAYS RETURNS TRUE.

Oh, wow! I'm sorry. I have no idea how that slipped through. The change seems simple, but I understand how it could cause problems.

I'm out of the office until the end of the week. Would you like me to ask someone from SWM if they have time to take a look, or should we pass it on to the externals? Otherwise, I can take care of this on Monday.

[stephanieelliott]

Thanks @JakubKorytko! Let's see if we can get any external proposals that will fix it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021935157794186843039