[Due for payment 2025-08-05] [$250] Invoice - Inconsistent behavior on "Report" field for invoice - Field is enabled when workspace has two open reports

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.69-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A https://expensify.testrail.io/index.php?/tests/view/6316668
Email or phone of affected tester (no customers): sdnjoijsdoijso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has enabled invoice feature.
• Workspace chat is empty (no expense report at all).

1. Go to staging.new.expensify.com
2. Open FAB > Send invoice.
3. Send an invoice to any user.
4. Go to workspace chat.
5. Click + > Create report.
6. Go to invoice room > Open invoice thread.
7. "Report" field is disabled and not clickable when workspace chat has one empty report.
8. Go to workspace chat.
9. Click + > Create report.
10. Go to invoice room > Open invoice thread.
11. Click on the Report field.

Expected Result:

In Step 7, "Report" field should be enabled and clickable when workspace chat has one empty report.

Actual Result:

In Step 7, "Report" field is disabled and not clickable when workspace chat has one empty report.
In Step 11, "Report" field is only enabled when workspace chat has at least two open reports.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937180150504288025
• Upwork Job ID: 1937180150504288025
• Last Price Increase: 2025-06-30
• Automatic offers:
• etCoderDysto | Contributor | 107881086

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Report" field is only enabled when workspace chat has at least two open reports

What is the root cause of that problem?

We call canEditFieldOfMoneyRequest function to determine if we can edit report field

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 207 in cb68c85

const canEditReport = canUserPerformWriteAction && canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.REPORT);

In the canEditFieldOfMoneyRequest function for report case, if the transaction has been reported, we check whether the user has more than one outstanding report that is associated with invoice's policyID. If there is only one or no outstanding report, the function returns false, and the report field will not be editable.

App/src/libs/ReportUtils.ts

Lines 4215 to 4220 in f2e7759

	if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {
	// Unreported transaction from OldDot can have the reportID as an empty string
	const isUnreported = !transaction?.reportID || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
	return isUnreported
	? Object.values(allPolicies ?? {}).flatMap((currentPolicy) => getOutstandingReportsForUser(currentPolicy?.id, currentUserAccountID, allReports ?? {})).length > 0
	: getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 1;

The invoice report won't be counted as a outstanding report since only a report type of expense is counted as outstanding report. Therefor the only report that is counted as the user's outstanding report will be the report that is created in workspace chat.

App/src/libs/ReportUtils.ts

Lines 9930 to 9941 in cb68c85

	function isReportOutstanding(
	iouReport: OnyxInputOrEntry<Report>,
	policyID: string | undefined,
	reportNameValuePairs: OnyxCollection<ReportNameValuePairs> = allReportNameValuePair,
	): boolean {
	if (!iouReport || isEmptyObject(iouReport)) {
	return false;
	}
	const reportNameValuePair = reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${iouReport.reportID}`];
	return (
	isExpenseReport(iouReport) &&
	iouReport?.stateNum !== undefined &&

What changes do you think we should make in order to solve the problem?

In canEditFieldOfMoneyRequest, we should return true if the report is an invoice report and there is more than zero outstanding report

if (isInvoiceReport(moneyRequestReport) && !isUnreported) {
            return getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 0;
        }
 return isUnreported
            ? Object.values(allPolicies ?? {}).flatMap((currentPolicy) => getOutstandingReportsForUser(currentPolicy?.id, currentUserAccountID, allReports ?? {})).length > 0
            : getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 1;
    

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

none

What alternative solutions did you explore? (Optional)

[clarajones-expensify]

Hi @vincdargento - I'm looking at this and am able to reproduce this, but when I do add a second expense report and am then able to change the report that the invoice is on, it doesn't actually change the report. Do you see the same behavior? Is this expected? Doesn't seem entirely right to me.

2025-06-19_15-04-55.mp4

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 7, "Report" field is disabled and not clickable when workspace chat has one empty report.
In Step 11, "Report" field is only enabled when workspace chat has at least two open reports.

What is the root cause of that problem?

1. Whether the report field is editable is determined here. It uses getOutstandingReportsForUser to filter the number of reports that satisfy the condition.
   

   App/src/libs/ReportUtils.ts

   Lines 4215 to 4221 in 90d39ec

   	if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {
   	// Unreported transaction from OldDot can have the reportID as an empty string
   	const isUnreported = !transaction?.reportID || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
   	return isUnreported
   	? Object.values(allPolicies ?? {}).flatMap((currentPolicy) => getOutstandingReportsForUser(currentPolicy?.id, currentUserAccountID, allReports ?? {})).length > 0
   	: getOutstandingReportsForUser(moneyRequestReport?.policyID, moneyRequestReport?.ownerAccountID, allReports ?? {}).length > 1;
   	}

2. In the getOutstandingReportsForUser function, the isReportOutstanding helper is used to filter the reports.
   

   App/src/libs/ReportUtils.ts

   Lines 9970 to 9972 in 90d39ec

   	return Object.values(reports)
   	.filter((report) => isReportOutstanding(report, policyID, reportNameValuePairs) && report?.ownerAccountID === reportOwnerAccountID)
   	.sort((a, b) => a?.reportName?.localeCompare(b?.reportName?.toLowerCase() ?? '') ?? 0);

3. In isReportOutstanding, various conditions are checked, including the isExpenseReport condition—therefore, only expense reports are accepted. As a result, the report field becomes editable only when two or more expense reports have been created.
   

   App/src/libs/ReportUtils.ts

   Line 9943 in 90d39ec

   isExpenseReport(iouReport) &&

What changes do you think we should make in order to solve the problem?

1. I believe that the role of isReportOutstanding is functioning as expected. When attempting to move to another report, an error is thrown stating that you cannot move with a report that has been approved. This error occurs whether the target report is an ExpenseReport or an InvoiceReport, meaning that moving an invoice report is not allowed.
2. Furthermore, after creating an invoice, the status and state of the invoice are both set to 1 (~ SUBMITTED). However, given the error when moving described above, it implies that the report is considered approved. And if moving to a different ExpenseReport were permitted, then it could subsequently be approved. This leads to a logical contradiction.

==> Therefore, my proposal is to disallow moving reports with an invoice.

App/src/libs/ReportUtils.ts

Line 4215 in 90d39ec

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.REPORT) {
     if (isInvoiceReport(moneyRequestReport)) {
         return false;
     }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Hi @vincdargento - I'm looking at this and am able to reproduce this, but when I do add a second expense report and am then able to change the report that the invoice is on, it doesn't actually change the report. Do you see the same behavior? Is this expected? Doesn't seem entirely right to me.

@clarajones-expensify I think we should leave the "Report" field disabled under all circumstances, just as outlined in my proposal above.

[melvin-bot]

@clarajones-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937180150504288025