Secondary log in - Extra gap under validation button - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Settings
2. Click on profile
3. Click on add phone number (secondary log in)
4. Check the button with dev tools

Expected Result:

Button area should only be consistent all around the button

Actual Result:

There's a empty gap below the button.

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-6

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637656551367400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Proposal

1. Remove the Extra margin from the button. Padding is already applied from the FixedFooter component around it.

   App/src/pages/settings/AddSecondaryLoginPage.js

   Line 152 in 03f1e76

   style={[styles.mb2]}

[deetergp]

Can be external and @parasharrajat's proposal takes care of it.

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted and invited @parasharrajat

https://www.upwork.com/ab/applicants/1463645267709853696/job-details
https://www.upwork.com/jobs/~01bdfa8ccd102ca443