[Due for payment 2025-07-23] [$250] Expense - Split is shown instead of Cancel payment in More menu when paying expense offline

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #63539
Email or phone of affected tester (no customers): sduiosjnosdjdsoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace settings > Workflows.
4. Disable "Delay submissions" and "Add approvals".
5. Go to workspace chat.
6. Go offline.
7. Submit an expense.
8. Click on the expense preview.
9. Pay elsewhere the expense.
10. Click More.

Expected Result:

Cancel payment option should be present in More menu.

Actual Result:

Split is shown instead of Cancel payment in More menu.
After returning online, Cancel payment is shown in More menu. Split option is gone (expected).

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6869514_1750855319095.20250625_203759.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021939824672462704983
• Upwork Job ID: 1939824672462704983
• Last Price Increase: 2025-06-30
• Automatic offers:
• allgandalf | Reviewer | 107908872
• FitseTLT | Contributor | 107908874

Issue Owner

Current Issue Owner: @francoisl

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Split is shown instead of Cancel payment in More menu when paying expense offline

What is the root cause of that problem?

We are not updating the iou report stateNum here so it remains at 1 in this case

App/src/libs/actions/IOU.ts

Line 8896 in 8107215

statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,

What changes do you think we should make in order to solve the problem?

We need to update the stateNum to approved

                stateNum: CONST.REPORT.STATE_NUM.APPROVED,

We need to make similar updates in other action utils where we have missed updating the stateNum optimistically.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test to assert payMoneyRequest updates the stateNum properly

What alternative solutions did you explore? (Optional)

[melvin-bot]

@lydiabarclay Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021939824672462704983

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)