[Due for payment 2025-08-11] [$50] Expense - Splits show error after non-admin approver splits the expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.74-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory https://expensify.testrail.io/index.php?/tests/view/6416429
Email or phone of affected tester (no customers): applausetester+010712kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Create a workspace with admin, non-admin approver and member.

1. Go to staging.new.expensify.com
2. [Member} Go to workspace chat.
3. [Member] Add an expense to the workspace chat. Do not click Submit button on expense preview.
4. [Non-admin approver] Go to workspace chat with member.
5. [Non-admin approver] Open the expense report.
6. [Non-admin approver] Click More > Split.
7. [Non-admin approver] Click Save.

Expected Result:

Non-admin approver should be able to split the expense.

Actual Result:

Non-admin approver is unable to split the expense. The splits show error after non-admin approver splits the expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021942678222792202966
• Upwork Job ID: 1942678222792202966
• Last Price Increase: 2025-07-28

Issue Owner

Current Issue Owner: @strepanier03 / @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[CortneyOfstad]

@jponikarchuk I'm confused by step 3:

Submit an expense to the workspace chat. Do not click Submit button on expense preview.

It mentions submitting the expense, but then states to not submit. Can you provide clarification?

[jponikarchuk]

@CortneyOfstad We mean that user should create an expense in the workspace chat but not click on Submit button.

[linhvovan29546]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-24 10:26:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Splits show error after non-admin approver splits the expense

What is the root cause of that problem?

The BE does not allow a non-admin approver to split an expense if the expense is still open.

What changes do you think we should make in order to solve the problem?

We should not display the split expense action if the expense is still open for non-admin approvers.

App/src/libs/ReportSecondaryActionUtils.ts

Line 101 in f660f73

return isSubmitter || isAdmin || isManager;

     if (isOpen) {
         return isSubmitter || isAdmin;
     }
    return isSubmitter || isAdmin || isManager;

I think we also handle a similar check on SplitExpensePage and SplitExpenseEditPage, so we can export the isSplitAction function and apply the same check here to display the 'Not Found' page.

App/src/pages/iou/SplitExpensePage.tsx

Line 55 in 0717d3f

import { isSplitAction as isSplitActionUtil } from '@libs/ReportSecondaryActionUtils';

...
    const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(reportID)}`, {canBeMissing: true});
    const policy=usePolicy(report?.policyID);
    const isSplitAction= report && transaction && isSplitActionUtil(report,[transaction],policy)
    // eslint-disable-next-line rulesdir/no-negated-variables
    const shouldShowNotFoundPage = isEmptyObject(draftTransaction) || !reportID || !isSplitAction
...
            <FullPageNotFoundView shouldShow={shouldShowNotFoundPage}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write a unit test for getSecondaryReportActions to ensure it does not return the SPLIT action for non-admin approvers when the expense is open.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

[CortneyOfstad]

Thanks for the clarification @jponikarchuk! Getting eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021942678222792202966