[$250] Expensify Card - "Expensify Card" text is not hyperlinked after logout and login

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.74-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+bm631@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

Precondition -
Admin has issued virtual card for himself

1. Go to https://staging.new.expensify.com/
2. Log out and then login
3. Go to the WS chat

Expected Result:

The "Expensify Card" text should still be a clickable link after logging in.

Actual Result:

After logging back in, the "Expensify Card" text appears as plain text without a hyperlink. It only becomes clickable again after visiting the Expensify Card page and returning.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6875845_1751452913784.bandicam_2025-07-02_13-38-28-761.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940612513769618516
• Upwork Job ID: 1940612513769618516
• Last Price Increase: 2025-07-03
• Automatic offers:
• suneox | Reviewer | 107978388
• daledah | Contributor | 107978389

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After logging back in, the "Expensify Card" text appears as plain text without a hyperlink. It only becomes clickable again after visiting the Expensify Card page and returning.

What is the root cause of that problem?

If it is policy admin, it will take the card data in allExpensifyCards which is not available at that time.
There for getExpensifyCardFromReportAction will return undefined. Thus, make the text is not hyperlinked

App/src/libs/CardMessageUtils.ts

Line 39 in 3cf1706

return isPolicyAdmin(getPolicy(policyID)) ? allExpensifyCards?.[cardID] : allUserCards[cardID];

What changes do you think we should make in order to solve the problem?

In case allExpensifyCards is not available yet, we will fallback to value in allUserCards

function getExpensifyCardFromReportAction({reportAction, policyID}: {reportAction?: ReportAction; policyID?: string;}): Card | undefined {
    const cardIssuedActionOriginalMessage = isCardIssuedAction(reportAction) ? getOriginalMessage(reportAction) : undefined;

    const cardID = cardIssuedActionOriginalMessage?.cardID ?? CONST.DEFAULT_NUMBER_ID;
    const workspaceAccountID = getWorkspaceAccountID(policyID);
    const allExpensifyCards = allWorkspaceCards?.[`cards_${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`] ?? {};
    // This will be fixed as part of https://github.com/Expensify/Expensify/issues/507850
    // eslint-disable-next-line deprecation/deprecation
    return isPolicyAdmin(getPolicy(policyID)) ? (allExpensifyCards?.[cardID] ?? allUserCards?.[cardID]) : allUserCards[cardID];
}

App/src/libs/CardMessageUtils.ts

Line 31 in 3cf1706

function getExpensifyCardFromReportAction({reportAction, policyID}: {reportAction?: ReportAction; policyID?: string}): Card | undefined {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940612513769618516

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[thelullabyy]

Proposal

Updated

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - "Expensify Card" text is not hyperlinked after logout and login

What is the root cause of that problem?

When logging out and logging in again, cards_${workspaceAccountID}_Expensify Card isn't loaded. So !!card in here will be falsy

App/src/libs/ReportActionsUtils.ts

Line 2860 in fd5c717

shouldRenderHTML && !!card ? `<a href='${environmentURL}/${navigateRoute}'>${translateLocal('cardPage.expensifyCard')}</a>` : translateLocal('cardPage.expensifyCard');

because the card parameter is obtained from cards_${workspaceAccountID}_Expensify Card (See detail in getExpensifyCardFromReportAction function)

What changes do you think we should make in order to solve the problem?

Instead of checking !!card, we only need to check !!cardID

App/src/libs/ReportActionsUtils.ts

Line 2860 in fd5c717

shouldRenderHTML && !!card ? `<a href='${environmentURL}/${navigateRoute}'>${translateLocal('cardPage.expensifyCard')}</a>` : translateLocal('cardPage.expensifyCard');

After applying the above change, when going to the detail card page, the not found page will display in a moment

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx

Lines 97 to 99 in fd5c717

	if (!card && !isLoadingOnyxValue(cardsListResult)) {
	return <NotFoundPage />;
	}

because OPEN_CARD_DETAILS_PAGE API can only be called when going to the detail card page (in the first rendering)

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx

Line 87 in fd5c717

useEffect(() => fetchCardDetails(), [fetchCardDetails]);

It takes time for the OPEN_CARD_DETAILS_PAGE API to return the card data

To fix this bug, we need to add a loading flag in optimisticData of openCardDetailsPage function and reset it in the success/failure data. Then we will use this flag to display a loading indicator in the detail card page and also prevent the not found page if it is loading

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should add UTs for getCardIssuedMessage function to cover the above case

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.