[Due for payment 2025-08-20] [$250] mWeb- LHN - Double chat messages when move expense to other workspace

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.77-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65310
Email or phone of affected tester (no customers): gocemate+b2153682approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A02s/12
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

1. Create a workspace with Admin, Approver and Member.

Steps

1. Go to the app
2. [Member] Submit an expense in the workspace chat.
3. [Member] Click Submit on the expense preview.
4. [Approver] Create a new workspace.
5. [Approver] Open workspace chat with member.
6. [Approver] Open the expense report.
7. [Approver] Click More > Change workspace.
8. [Approver] Select the new workspace.
9. [Approver] Open the workspace chat with member from Step 5.

Expected Result:

There should be only one message " User owes..."

Actual Result:

Double chat messages when move expense to other workspace

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021942581813581610068
• Upwork Job ID: 1942581813581610068
• Last Price Increase: 2025-07-15
• Automatic offers:
• truph01 | Contributor | 108079583

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Duplicate chat messages appear when an expense is moved to another workspace.

What is the root cause of that problem?

• When changing the workspace, we have logic here:
  

  App/src/libs/actions/Report.ts

  Lines 5575 to 5586 in 46b6aef

  	// 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID
  	// and set it as a parent of the moved report
  	const policyExpenseChat = getPolicyExpenseChat(currentUserAccountID, policyID);
  	const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report);
  	const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;
  	optimisticData.push({
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${newPolicyExpenseChatReportID}`,
  	value: {[optimisticReportPreviewAction.reportActionID]: optimisticReportPreviewAction},
  	});

This logic creates a new REPORT_PREVIEW report action and adds it to the policy expense chat. However, we are always adding it to the current user's policy expense chat, instead of the policy expense chat of the user who owns the expense report (optimistically).

• Meanwhile, the backend also creates a new REPORT_PREVIEW report action, but it correctly adds it to the policy expense chat of the actual owner of the expense report.

• As a result, the "User owes..." message appears twice in the LHN.

What changes do you think we should make in order to solve the problem?

• In this function:
  

  App/src/libs/actions/Report.ts

  Line 5451 in 46b6aef

  function buildOptimisticChangePolicyData(report: Report, policyID: string, reportNextStep?: ReportNextStep) {

Introduce a third parameter: optimisticPolicyExpenseChatReport?: Report. This will help handle two cases:

1. When the policy expense chat hasn’t been created yet.
2. When the policy expense chat has already been created.

• Then, update the logic here:
  

  App/src/libs/actions/Report.ts

  Lines 5575 to 5580 in 46b6aef

  	// 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID
  	// and set it as a parent of the moved report
  	const policyExpenseChat = getPolicyExpenseChat(currentUserAccountID, policyID);
  	const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report);
  	const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;

Update it as follows:

    // 3. Optimistically create a new REPORT_PREVIEW reportAction with the newReportPreviewActionID
    // and set it as a parent of the moved report
    const policyExpenseChat = optimisticPolicyExpenseChatReport ?? getPolicyExpenseChat(report.ownerAccountID, policyID);
    const optimisticReportPreviewAction = buildOptimisticReportPreview(policyExpenseChat, report);

    const newPolicyExpenseChatReportID = policyExpenseChat?.reportID;

3. In:
   

   App/src/libs/actions/Report.ts

   Line 5713 in 46b6aef

   } = buildOptimisticChangePolicyData(report, policyID);

   
   pass membersChats.reportCreationData[submitterEmail] as 3rd param.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021942581813581610068

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[melvin-bot]

@DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

@DylanDylann have you had a chance to review the proposal?