[Due for payment 2025-08-07] [$250] Room - After creating room and changing priority mode offline, room shows skeleton

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.77-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/461683
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.3 - Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account > Preferences.
3. Click Priority mode.
4. Select #focus.
5. Go offline.
6. Open FAB > Start chat > # Room.
7. Create a room.
8. Go to Account > Preferences.
9. Click Priority mode.
10. Select Most recent.
11. Go back to Inbox.

Expected Result:

The welcome message is displayed. (It was fixed here #54180)

Actual Result:

The room shows skeleton loading.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6870799_1750950649031.1750802215724_20250625_055622.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021945061871735826129
• Upwork Job ID: 1945061871735826129
• Last Price Increase: 2025-07-15
• Automatic offers:
• nkdengineer | Contributor | 108085229

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The room shows skeleton loading.

What is the root cause of that problem?

Here is the condition to show the skeleton

App/src/pages/home/report/ReportActionsView.tsx

Lines 278 to 280 in cf56a40

	if ((isLoadingInitialReportActions && (isReportDataIncomplete || isMissingReportActions) && !isOffline) ?? isLoadingApp) {
	return <ReportActionsSkeletonView />;
	}

in this case, isLoadingInitialReportActions is undefined so isLoadingApp is used to decide to show the skeleton or not

But if we change the priority mode, we will update isLoadingApp to true so the skeleton is shown

What changes do you think we should make in order to solve the problem?

We already checked for !isOffline on the left-hand side operand

so we should update this condition

App/src/pages/home/report/ReportActionsView.tsx

Lines 278 to 280 in cf56a40

	if ((isLoadingInitialReportActions && (isReportDataIncomplete || isMissingReportActions) && !isOffline) ?? isLoadingApp) {
	return <ReportActionsSkeletonView />;
	}

to

    if ((isLoadingInitialReportActions && (isReportDataIncomplete || isMissingReportActions) && !isOffline) ?? (isLoadingApp && !isOffline)) {

by doing that, we only show the ReportActionsSkeletonView in online mode

We also can update this condition to check isOffline

App/src/pages/home/report/ReportActionsView.tsx

Lines 282 to 284 in cf56a40

	if (isMissingReportActions) {
	return <ReportActionsSkeletonView shouldAnimate={false} />;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - After creating room and changing priority mode offline, room shows skeleton

What is the root cause of that problem?

We show the skeleton here.

App/src/pages/home/report/ReportActionsView.tsx

Lines 285 to 287 in 11ff1d3

	if ((isLoadingInitialReportActions && (isReportDataIncomplete || isMissingReportActions) && !isOffline) ?? isLoadingApp) {
	return <ReportActionsSkeletonView />;
	}

In this case, isLoadingInitialReportActions is undefined, so isLoadingApp is used to decide whether to show the skeleton or not

But if we change the priority mode, we will update isLoadingApp to true, so the skeleton is shown

What changes do you think we should make in order to solve the problem?

We can keep the fix from #54180. We only need to update isLoadingInitialReportActions

App/src/pages/home/ReportScreen.tsx

Lines 814 to 822 in 11ff1d3

	<ReportActionsView
	report={report}
	reportActions={reportActions}
	isLoadingInitialReportActions={reportMetadata?.isLoadingInitialReportActions}
	hasNewerActions={hasNewerActions}
	hasOlderActions={hasOlderActions}
	parentReportAction={parentReportAction}
	transactionThreadReportID={transactionThreadReportID}
	/>

to this

          isLoadingInitialReportActions={reportMetadata?.isLoadingInitialReportActions ?? (!reportMetadata?.isOptimisticReport && isLoadingApp)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021945061871735826129

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)