[Awaiting Checklist] [Due for payment 2025-08-11] [$250] Question Mark Icon Appears to the Right of Close Icon in "Explore Plans" Modal

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.79-11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to Account → Subscription → Explore plans
2. Observe the top-right corner of the modal

Expected Result:

The close icon (×) should be the rightmost icon in the modal header.
The question mark icon, if present at all, should be placed to the left of the close icon or removed if not relevant to the context

Actual Result:

The question mark icon appears to the far right, pushing the close icon leftward

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021943737604369214691
• Upwork Job ID: 1943737604369214691
• Last Price Increase: 2025-07-18
• Automatic offers:
• FitseTLT | Contributor | 108164313

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Question Mark Icon Appears to the Right of Close Icon in "Explore Plans" Modal

What is the root cause of that problem?

We haven't passed shouldDisplayHelpButton as false

App/src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx

Line 74 in 509bd7b

shouldShowBackButton={false}

What changes do you think we should make in order to solve the problem?

We should pass false

                shouldDisplayHelpButton={false}

But if we want to display it to the left of close button we should create a variation in HeaderWithBackButton with a new prop shouldDisplayHelpLeftOfClose then we will display the help button here when the prop is true

App/src/components/HeaderWithBackButton/index.tsx

Lines 294 to 295 in 509bd7b

	{shouldShowCloseButton && (
	<Tooltip text={translate('common.close')}>

                    {shouldDisplayHelpButton && shouldDisplayHelpLeftOfClose && <HelpButton />}

then

App/src/components/HeaderWithBackButton/index.tsx

Line 310 in 509bd7b

{shouldDisplayHelpButton && <HelpButton />}

                {shouldDisplayHelpButton && !shouldDisplayHelpLeftOfClose & <HelpButton />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021943737604369214691

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[mehrozone]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Question Mark Icon Appears to the Right of Close Icon in "Explore Plans" Modal

What is the root cause of that problem?

The root cause of this issue is the order of component rendering, the CloseButton is rendered before the HelpButton and SearchButton in the code. As a common design pattern, the close button should always appear as the last action item, whether it’s aligned to the far left or far right. Rendering it earlier in the code causes it to appear in an incorrect position relative to the other action buttons.

src/componenets/HeaderWithBackButton/index.ts

                    {shouldShowCloseButton && (
                        <Tooltip text={translate('common.close')}>
                            <PressableWithoutFeedback
                                onPress={onCloseButtonPress}
                                style={[styles.touchableButtonImage]}
                                role={CONST.ROLE.BUTTON}
                                accessibilityLabel={translate('common.close')}
                            >
                                <Icon
                                    src={Expensicons.Close}
                                    fill={iconFill ?? theme.icon}
                                />
                            </PressableWithoutFeedback>
                        </Tooltip>
                    )}
                </View>
                {shouldDisplayHelpButton && <HelpButton />}
                {shouldDisplaySearchRouter && <SearchButton />}

What changes do you think we should make in order to solve the problem?

To resolve this, we should reorder the rendering of buttons in the header so that the CloseButton is always rendered last. This ensures it consistently appears at the end of the header layout, regardless of which other buttons are present.

src/componenets/HeaderWithBackButton/index.ts

{shouldDisplayHelpButton && <HelpButton />}
                {shouldDisplaySearchRouter && <SearchButton />}
                {shouldShowCloseButton && (
                        <Tooltip text={translate('common.close')}>
                            <PressableWithoutFeedback
                                onPress={onCloseButtonPress}
                                style={[styles.touchableButtonImage]}
                                role={CONST.ROLE.BUTTON}
                                accessibilityLabel={translate('common.close')}
                            >
                                <Icon
                                    src={Expensicons.Close}
                                    fill={iconFill ?? theme.icon}
                                />
                            </PressableWithoutFeedback>
                        </Tooltip>
                    )}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Tests

• Add UI tests to confirm that the CloseButton always appears as the last button in the header.
• Include conditional cases where the HelpButton and/or SearchButton may or may not be rendered to ensure consistency in button order across all variations.

What alternative solutions did you explore? (Optional)

An alternative considered was introducing a new prop to control the position of the CloseButton, but this would introduce unnecessary complexity. Since in nearly all use cases the close button should be the last element, reordering the rendering logic is the most straightforward and maintainable solution.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[adel-gu]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The modal header displays the help (question mark) icon on the far right, causing the close (×) icon to appear left of it.

What is the root cause of that problem?

In the HeaderWithBackButton layout, the <HelpButton /> component is rendered after the close button, placing it visually to the right of the close icon in the modal header.

App/src/components/HeaderWithBackButton/index.tsx

Lines 302 to 310 in 8b943bb

	<Icon
	src={Expensicons.Close}
	fill={iconFill ?? theme.icon}
	/>
	</PressableWithoutFeedback>
	</Tooltip>
	)}
	</View>
	{shouldDisplayHelpButton && <HelpButton />}

What changes do you think we should make in order to solve the problem?

1. Move the <HelpButton /> component so it is rendered before the close button.

       {shouldDisplayHelpButton && <HelpButton />}
       <View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter]}...>

2. Then, to ensure styling consistency, remove styles.reportOptions from the View containing the close button and add it to the help button like so:

       {shouldDisplayHelpButton && <HelpButton style={styles.reportOptions} />}
       <View style={[styles.flexRow, styles.alignItemsCenter]}...>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We should add a unit test for HeaderWithBackButton that queries all buttons rendered in the header and asserts their correct order.

What alternative solutions did you explore? (Optional)

• Move the <HelpButton /> and <SearchButton /> before the close button, to ensure the close button is always on the rightmost.

{shouldDisplayHelpButton && <HelpButton />}
                {shouldDisplaySearchRouter && <SearchButton />}
                <View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter]}...>

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @adel-gu! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>