Expense - Confirm modal appears with delay after selecting Mark as paid when expense is held

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #65296
Email or phone of affected tester (no customers): jsdnoijdoijdsojsd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Disable "Delay submissions" and "Add approvals" in Workflows settings.

1. Go to staging.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Open the expense report.
5. Click More > Hold.
6. Enter reason and save it,
7. Click More > Mark as paid.

Expected Result:

Confirmation modal will appear immediately after selecting Mark as paid.

Actual Result:

There is delay before confirmation modal appears after selecting Mark as paid when expense is held.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirm modal appears with delay after selecting Mark as paid when expense is held

What is the root cause of that problem?

We are using InteractionManager.runAfterInteractions

App/src/components/MoneyReportHeader.tsx

Lines 325 to 335 in 8b943bb

	const confirmPayment = useCallback(
	(type?: PaymentMethodType | undefined, payAsBusiness?: boolean, methodID?: number, paymentMethod?: PaymentMethod) => {
	if (!type || !chatReport) {
	return;
	}
	setPaymentType(type);
	setRequestType(CONST.IOU.REPORT_ACTION_TYPE.PAY);
	if (isDelegateAccessRestricted) {
	showDelegateNoAccessModal();
	} else if (isAnyTransactionOnHold) {
	InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));

that cause this delay here, on IOS native when we call confirmPayment function and if AnyTransactionOnHold then previous menu does not close properly before showing holdMenu.

What changes do you think we should make in order to solve the problem?

We should remove InteractionManager.runAfterInteractions for all platform except IOSNative

const isIOSNative = getPlatform() === CONST.PLATFORM.IOS;
.
.

} else if (isAnyTransactionOnHold) {
if (isIOSNative) {
    InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));
} else {
    setIsHoldMenuVisible(true);
}

here

App/src/components/MoneyReportHeader.tsx

Lines 334 to 335 in 4668539

	} else if (isAnyTransactionOnHold) {
	InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rushatgabhane]

@BlameGPT please find the culprits