Web - Settings - Pressing tab on password field won't go straight to next one

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing the PR #6501

Action Performed:

1. Open app and login
2. Go to profile > change password
3. Click on first field and type pass
4. Press Tab key

Expected Result:

User is brought to the next fillable field

Actual Result:

After pressing tab, focus goes to new hide/show password icon.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.18.0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Issue was found when executing the PR #6501

Bug5362473_Untitled_82.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

This is the technically correct flow for tab navigation so this is not an issue.

[isagoico]

@anthony-hull I agree with @parasharrajat here - I think this is the expected behaviour now with the new Visibility toggle - can you confirm so we can close this issue 😬 Thanks in advance

[anthony-hull]

I agree it should go to the visibility toggle before the next field.
We shouldn't make the toggle unreachable in keyboard navigation and putting it in another position in the tab index would negatively affect the context for the control to the input.

[NikkiWines]

Cool, sounds like this is a non-issue, closing as this is not a deploy blocker.