[Due for payment 2025-10-15] [Due for payment 2025-09-30] [$250] We show delete button for unreported card expenses imported with deleting disabled

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.83-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Connect a card feed
2. Make sure "allow deleting transactions" is disabled
3. Assign a card with expenses
4. Unreport the expenses
5. Go to your personal space
6. Tap one of the expenses.

Expected Result:

We hide the option to delete the expenses, since it maps back to a card on a workspace where transaction deleting is disabled.

Actual Result:

We show delete button, but throw an API error when you try to delete.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2025-07-17_15-36-54.mp4

Recording.1432.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021948036590874577665
• Upwork Job ID: 1948036590874577665
• Last Price Increase: 2025-08-23

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We show delete button for unreported card expenses imported with deleting disabled

What is the root cause of that problem?

We currently show the delete button for unreported when the user is the owner. The issue occurs because we do not check if the card expense was imported with deletion disabled.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 439 to 441 in 233790a

	if (isUnreported) {
	return isOwner;
	}

What changes do you think we should make in order to solve the problem?

We should update the condition to handle this case by checking if the card transaction is imported with deletion disabled.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 439 to 441 in 233790a

	if (isUnreported) {
	return isOwner;
	}

    if (isUnreported) {
// Instead of checking for RESTRICT below, we can use canDeleteCardTransactionByLiabilityType to check for the ALLOW type. => isOwner && canDeleteCardTransactionByLiabilityType(transaction)
        const isCardTransactionWithCorporateLiability = isCardTransactionUtils(transaction) && transaction?.comment?.liabilityType === CONST.TRANSACTION.LIABILITY_TYPE.RESTRICT;
        return isOwner && !isCardTransactionWithCorporateLiability;
    }

And here when right click the IOU to display the popover

App/src/libs/ReportUtils.ts

Line 2521 in 233790a

if (isActionOwner) {

        if (isActionOwner) {
            // Alternatively, we can return early here if isCardTransactionCanBeDeleted is false, like this: if(!isCardTransactionCanBeDeleted){return false}
            if(isTrackExpenseAction(reportAction)){
                return isCardTransactionCanBeDeleted
            }
          ... Other 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should write tests for getSecondaryReportActions to ensure it does not return the DELETE action and for the isDeleteAction

What alternative solutions did you explore? (Optional)

Return early if isCardTransactionWithCorporateLiability is true. The condition could be moved up, like so:

App/src/libs/ReportSecondaryActionUtils.ts

Line 438 in 233790a

        const isCardTransactionWithCorporateLiability =
            isSingleTransaction && isCardTransactionUtils(transaction) && transaction?.comment?.liabilityType === CONST.TRANSACTION.LIABILITY_TYPE.RESTRICT;

        if (isCardTransactionWithCorporateLiability) {
            return false;
        }

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021948036590874577665

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)