[Due for payment 2025-08-13] Fix canBeMissing alert for for key transactionsDraft_1

[iwiznia]

Keys: transactionsDraft_1
OG issue: https://github.com/Expensify/Expensify/issues/509588
Suspect introduction in #61760 from #65032 (comment)

@SzymczakJ you are the author of that PR, can you take a look at this please?

[SzymczakJ]

I cannot reproduce it, do you have the reproduction steps?
Or should I just blindly set canBeMissing to false here?

[iwiznia]

I cannot reproduce it, do you have the reproduction steps?

No, it's just a log line. You went through those flows and can't see it?

Or should I just blindly set canBeMissing to false here?

No, do not blindly do it. Is this flow expecting to always have a draftTransaction in that case? What should be creating/loading it? Does the code work if the data is not there?

[SzymczakJ]

I went through the flows a couple of times and cannot reproduce it, that's why I asked for the repro steps.
I will dig deeper tomorrow 🫡

[SzymczakJ]

I managed to reproduce it. I think it is safe to set canBeMissing to true:

1. IOURequestStepAmount uses transactionDraft only for computing currency, when this is edit flow. In that flow the transactionDraft is always there and canBeMissing alert is not shown. The alert is shown in creation flow in which transactionDraft is not needed because we use normal transaction so in that case it can be missing.
2. Even when transactionDraft is missing we have fallback logic that uses normal transaction, so nothing gets broken.
3. Every other usage of ONYXKEYS.COLLECTION.TRANSACTION_DRAFT key is set to canBeMissing to true

[SzymczakJ]

FYI I'll be OOO for the whole next week.