[$250] Reports - Missing Approve option in dropdown menu when report is pending approval

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2148171/test-runs/TR-184/folder/12015306/39317675/801697103?sort=%2Bidentifier
Email or phone of affected tester (no customers): sdoinjsdoijisod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

1. Go to staging.expensify.com
2. Log in with a new account.
3. Create a workspace chat.
4. Go to workspace chat.
5. Submit an expense.
6. Click Submit on the expense preview.
7. Go to Reports > Reports.
8. Select the report via checkbox.
9. Click on the dropdown button.
   → Note that Approve option is present in the dropdown menu.
10. Go back to the workspace chat.
11. Create an empty report via + > Create report.
12. Go to Reports > Reports.
13. Select the report from Step 5 via checkbox.
14. Click on the dropdown button.

Expected Result:

Approve option will be present in the dropdown menu after creating an empty report because the selected report can be approved.

Actual Result:

Approve option is missing in the dropdown menu after creating an empty report when there is report pending for approval.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021949708734967569270
• Upwork Job ID: 1949708734967569270
• Last Price Increase: 2025-07-28

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing approve button when there is an empty report.

What is the root cause of that problem?

The approve button will show if every selected report has 'approve' action.

App/src/pages/Search/SearchPage.tsx

Lines 160 to 165 in 549b46a

	const shouldShowApproveOption =
	!isOffline &&
	!isAnyTransactionOnHold &&
	(selectedReports.length
	? selectedReports.every((report) => report.action === CONST.SEARCH.ACTION_TYPES.APPROVE)
	: selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.APPROVE));

However, when there is an empty report, it's also counted as the selectedReports. The selectedReports is calculated by filtering out the search data by checking if the report has a transaction that is selected using .every.

App/src/components/Search/SearchContext.tsx

Lines 92 to 96 in 549b46a

	if (data.length && data.every(isTransactionReportGroupListItemType)) {
	selectedReports = data
	.filter((item) => isMoneyRequestReport(item) && item.transactions.every(({keyForList}) => selectedTransactions[keyForList]?.isSelected))
	.map(({reportID, action = CONST.SEARCH.ACTION_TYPES.VIEW, total = CONST.DEFAULT_NUMBER_ID, policyID}) => ({reportID, action, total, policyID}));
	}

But since the transaction is empty for the empty report, .every returns true, so it's counted in the selectedReports.

What changes do you think we should make in order to solve the problem?

We should check if the transaction is not empty before using .every.

.filter((item) => isMoneyRequestReport(item) && item.transactions.length > 0 && item.transactions.every(({keyForList}) => selectedTransactions[keyForList]?.isSelected))

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test the useSearchContext hook and calls setSelectedTransactions with the data that contains empty report and verify it's not counted in selectedReports.

[RachCHopkins]

Repro'd - how bizarre! And if I delete the second empty report, the Approve option returns!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021949708734967569270